auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature

commit 4424c35ead upstream.

It seems that the lcd2s_redefine_char() has never been properly
tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
by the character number (from 0 to 7), but immediately after that
these bytes are rewritten by the decoded hex stream.

Fix the index to fill the buffer after the command and number.

Fixes: 8c9108d014 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
[fixed typo in commit message]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Andy Shevchenko

2022-02-23 17:47:16 +02:00

committed by

Greg Kroah-Hartman

parent 4efa386ef9

commit f9c3aa939c

1 changed files with 1 additions and 1 deletions

									
										drivers/auxdisplay/lcd2s.c
									
		+1
		-1
	
												View File
												
				@@ -238,7 +238,7 @@ static int lcd2s_redefine_char(struct charlcd *lcd, char *esc)

					if (buf[1] > 7)

						return 1;

					i = 0;

					i = 2;

					shift = 0;

					value = 0;

					while (*esc && i < LCD2S_CHARACTER_SIZE + 2) {