tools: ynl-gen: don't consider requests with fixed hdr empty
C codegen skips generating the structs if request/reply has no attrs. In such cases the request op takes no argument and return int (rather than response struct). In case of classic netlink a lot of information gets passed using the fixed struct, however, so adjust the logic to consider a request empty only if it has no attrs _and_ no fixed struct. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Link: https://patch.msgid.link/20250410014658.782120-9-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
@@ -1247,6 +1247,9 @@ class RenderInfo:
|
||||
if op_mode == 'event':
|
||||
self.struct['reply'] = Struct(family, self.attr_set, type_list=op['event']['attributes'])
|
||||
|
||||
def type_empty(self, key):
|
||||
return len(self.struct[key].attr_list) == 0 and self.fixed_hdr is None
|
||||
|
||||
|
||||
class CodeWriter:
|
||||
def __init__(self, nlib, out_file=None, overwrite=True):
|
||||
@@ -2034,7 +2037,7 @@ def print_type_helpers(ri, direction, deref=False):
|
||||
|
||||
|
||||
def print_req_type_helpers(ri):
|
||||
if len(ri.struct["request"].attr_list) == 0:
|
||||
if ri.type_empty("request"):
|
||||
return
|
||||
print_alloc_wrapper(ri, "request")
|
||||
print_type_helpers(ri, "request")
|
||||
@@ -2057,7 +2060,7 @@ def print_parse_prototype(ri, direction, terminate=True):
|
||||
|
||||
|
||||
def print_req_type(ri):
|
||||
if len(ri.struct["request"].attr_list) == 0:
|
||||
if ri.type_empty("request"):
|
||||
return
|
||||
print_type(ri, "request")
|
||||
|
||||
|
||||
Reference in New Issue
Block a user