selftests/net/ipsec: Fix Null pointer dereference in rtattr_pack()

[ Upstream commit 3a0b7fa095 ]

Address Null pointer dereference / undefined behavior in rtattr_pack
(note that size is 0 in the bad case).

Flagged by cppcheck as:
    tools/testing/selftests/net/ipsec.c:230:25: warning: Possible null pointer
    dereference: payload [nullPointer]
    memcpy(RTA_DATA(attr), payload, size);
                           ^
    tools/testing/selftests/net/ipsec.c:1618:54: note: Calling function 'rtattr_pack',
    4th argument 'NULL' value is 0
    if (rtattr_pack(&req.nh, sizeof(req), XFRMA_IF_ID, NULL, 0)) {
                                                       ^
    tools/testing/selftests/net/ipsec.c:230:25: note: Null pointer dereference
    memcpy(RTA_DATA(attr), payload, size);
                           ^
Signed-off-by: Liu Ye <liuye@kylinos.cn>

Link: https://patch.msgid.link/20250116013037.29470-1-liuye@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Liu Ye

2025-01-16 09:30:37 +08:00

committed by

Greg Kroah-Hartman

parent 44b4b97439

commit decefd4131

1 changed files with 2 additions and 1 deletions

									
										tools/testing/selftests/net/ipsec.c
									
		+2
		-1
	
												View File
												
				@@ -227,7 +227,8 @@ static int rtattr_pack(struct nlmsghdr *nh, size_t req_sz,

					attr->rta_len = RTA_LENGTH(size);

					attr->rta_type = rta_type;

					memcpy(RTA_DATA(attr), payload, size);

					if (payload)

						memcpy(RTA_DATA(attr), payload, size);

					return 0;

				}