TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NETFILTER: nfnetlink_log: fix reference counting

Browse Source 
[NETFILTER]: nfnetlink_log: fix reference counting

Fix reference counting (memory leak) problem in __nfulnl_send() and callers
related to packet queueing.

Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Michal Miroslaw
2007-03-13 16:45:26 +01:00
committed by Greg Kroah-Hartman
parent 0065572ae6
commit d684641802
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/netfilter/nfnetlink_log.c
+2 -6
View File
@@ -218,10 +218,8 @@ _instance_destroy2(struct nfulnl_instance *inst, int lock)
spin_lock_bh(&inst->lock);
if (inst->skb) {
/* timer "holds" one reference (we have one more) */
if (timer_pending(&inst->timer)) {
del_timer(&inst->timer);
if (del_timer(&inst->timer))
instance_put(inst);
}
if (inst->qlen)
__nfulnl_send(inst);
if (inst->skb) {
@@ -695,10 +693,8 @@ nfulnl_log_packet(unsigned int pf,
UDEBUG("flushing old skb\n");
/* timer "holds" one reference (we have another one) */
if (timer_pending(&inst->timer)) {
del_timer(&inst->timer);
if (del_timer(&inst->timer))
instance_put(inst);
}
__nfulnl_send(inst);
if (!(inst->skb = nfulnl_alloc_skb(nlbufsiz, size))) {