platform/chrome: cros_ec_typec: fix missing fwnode reference decrement

commit 9c41f37145 upstream.

The device_for_each_child_node() macro requires explicit calls to
fwnode_handle_put() upon early exits (return, break, goto) to decrement
the fwnode's refcount, and avoid levaing a node reference behind.

Add the missing fwnode_handle_put() after the common label for all error
paths.

Cc: stable@vger.kernel.org
Fixes: fdc6b21e24 ("platform/chrome: Add Type C connector class driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241013-cross_ec_typec_fwnode_handle_put-v2-1-9182b2cd7767@gmail.com
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Javier Carrasco

2024-10-13 15:20:24 +02:00

committed by

Greg Kroah-Hartman

parent 082dc185b8

commit d427e3aa84

1 changed files with 1 additions and 0 deletions

									
										drivers/platform/chrome/cros_ec_typec.c
									
		+1
		
												View File
												
				@@ -446,6 +446,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)

					return 0;

				unregister_ports:

					fwnode_handle_put(fwnode);

					cros_unregister_ports(typec);

					return ret;

				}