media: uvcvideo: Fix double free in error path

commit c6ef3a7fa9 upstream.

If the uvc_status_init() function fails to allocate the int_urb, it will
free the dev->status pointer but doesn't reset the pointer to NULL. This
results in the kfree() call in uvc_status_cleanup() trying to
double-free the memory. Fix it by resetting the dev->status pointer to
NULL after freeing it.

Fixes: a31a405547 ("V4L/DVB:usbvideo:don't use part of buffer for USB transfer #4")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20241107235130.31372-1-laurent.pinchart@ideasonboard.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Laurent Pinchart

2024-11-08 01:51:30 +02:00

committed by

Greg Kroah-Hartman

parent f2013d19b7

commit d1f8e69eec

1 changed files with 1 additions and 0 deletions

									
										drivers/media/usb/uvc/uvc_status.c
									
		+1
		
												View File
												
				@@ -269,6 +269,7 @@ int uvc_status_init(struct uvc_device *dev)

					dev->int_urb = usb_alloc_urb(0, GFP_KERNEL);

					if (!dev->int_urb) {

						kfree(dev->status);

						dev->status = NULL;

						return -ENOMEM;

					}