TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/panel: lg-sw43408: add missing error handling

Browse Source 
[ Upstream commit 51f9183e4a ]

Add missing error handling for the mipi_dsi_ functions that actually
return error code instead of silently ignoring it.

Fixes: 069a6c0e94 ("drm: panel: Add LG sw43408 panel driver")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240512-dsi-panels-upd-api-v2-1-e31ca14d102e@linaro.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240512-dsi-panels-upd-api-v2-1-e31ca14d102e@linaro.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dmitry Baryshkov
2024-05-12 02:00:18 +03:00
committed by Greg Kroah-Hartman
parent 6f793d8528
commit ca503105cb
1 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/gpu/drm/panel/panel-lg-sw43408.c
+27 -6
View File
@@ -62,16 +62,25 @@ static int sw43408_program(struct drm_panel *panel)
{
struct sw43408_panel *ctx = to_panel_info(panel);
struct drm_dsc_picture_parameter_set pps;
int ret;
mipi_dsi_dcs_write_seq(ctx->link, MIPI_DCS_SET_GAMMA_CURVE, 0x02);
mipi_dsi_dcs_set_tear_on(ctx->link, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
ret = mipi_dsi_dcs_set_tear_on(ctx->link, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
if (ret < 0) {
dev_err(panel->dev, "Failed to set tearing: %d\n", ret);
return ret;
}
mipi_dsi_dcs_write_seq(ctx->link, 0x53, 0x0c, 0x30);
mipi_dsi_dcs_write_seq(ctx->link, 0x55, 0x00, 0x70, 0xdf, 0x00, 0x70, 0xdf);
mipi_dsi_dcs_write_seq(ctx->link, 0xf7, 0x01, 0x49, 0x0c);
mipi_dsi_dcs_exit_sleep_mode(ctx->link);
ret = mipi_dsi_dcs_exit_sleep_mode(ctx->link);
if (ret < 0) {
dev_err(panel->dev, "Failed to exit sleep mode: %d\n", ret);
return ret;
}
msleep(135);
@@ -97,14 +106,22 @@ static int sw43408_program(struct drm_panel *panel)
mipi_dsi_dcs_write_seq(ctx->link, 0x55, 0x04, 0x61, 0xdb, 0x04, 0x70, 0xdb);
mipi_dsi_dcs_write_seq(ctx->link, 0xb0, 0xca);
mipi_dsi_dcs_set_display_on(ctx->link);
ret = mipi_dsi_dcs_set_display_on(ctx->link);
if (ret < 0) {
dev_err(panel->dev, "Failed to set display on: %d\n", ret);
return ret;
}
msleep(50);
ctx->link->mode_flags &= ~MIPI_DSI_MODE_LPM;
drm_dsc_pps_payload_pack(&pps, ctx->link->dsc);
mipi_dsi_picture_parameter_set(ctx->link, &pps);
ret = mipi_dsi_picture_parameter_set(ctx->link, &pps);
if (ret < 0) {
dev_err(panel->dev, "Failed to set PPS: %d\n", ret);
return ret;
}
ctx->link->mode_flags |= MIPI_DSI_MODE_LPM;
@@ -113,8 +130,12 @@ static int sw43408_program(struct drm_panel *panel)
* PPS 1 if pps_identifier is 0
* PPS 2 if pps_identifier is 1
*/
mipi_dsi_compression_mode_ext(ctx->link, true,
MIPI_DSI_COMPRESSION_DSC, 1);
ret = mipi_dsi_compression_mode_ext(ctx->link, true,
MIPI_DSI_COMPRESSION_DSC, 1);
if (ret < 0) {
dev_err(panel->dev, "Failed to set compression mode: %d\n", ret);
return ret;
}
return 0;
}