nfsd: fix refcount leak when file is unhashed after being found

[ Upstream commit 8a79261763 ]

If we wait_for_construction and find that the file is no longer hashed,
and we're going to retry the open, the old nfsd_file reference is
currently leaked. Put the reference before retrying.

Fixes: c6593366c0 ("nfsd: don't kill nfsd_files because of lease break error")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Tested-by: Youzhong Yang <youzhong@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Jeff Layton

2024-07-10 09:05:32 -04:00

committed by

Greg Kroah-Hartman

parent 0b5bc6d1f2

commit bef565d739

1 changed files with 1 additions and 0 deletions

									
										fs/nfsd/filecache.c
									
		+1
		
												View File
												
				@@ -1054,6 +1054,7 @@ wait_for_construction:

							status = nfserr_jukebox;

							goto construction_err;

						}

						nfsd_file_put(nf);

						open_retry = false;

						goto retry;

					}