btrfs: ioctl: remove unnecessary call to btrfs_mark_buffer_dirty()
The call to btrfs_mark_buffer_dirty() at btrfs_ioctl_default_subvol() is not necessary as we have a path setup for writing with btrfs_search_slot() having a 'cow' argument set to 1. This just makes the code more verbose, confusing and add a little extra overhead and well as increase the module's text size, so remove it. Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
committed by
David Sterba
parent
212e5f5cb8
commit
bd25bf9dcd
@@ -2916,7 +2916,6 @@ static long btrfs_ioctl_default_subvol(struct file *file, void __user *argp)
|
||||
|
||||
btrfs_cpu_key_to_disk(&disk_key, &new_root->root_key);
|
||||
btrfs_set_dir_item_key(path->nodes[0], di, &disk_key);
|
||||
btrfs_mark_buffer_dirty(trans, path->nodes[0]);
|
||||
btrfs_release_path(path);
|
||||
|
||||
btrfs_set_fs_incompat(fs_info, DEFAULT_SUBVOL);
|
||||
|
||||
Reference in New Issue
Block a user