cpufreq: mediatek-hw: Fix wrong return value in mtk_cpufreq_get_cpu_power()

commit 172bf5ed04 upstream.

mtk_cpufreq_get_cpu_power() return 0 if the policy is NULL. Then in
em_create_perf_table(), the later zero check for power is not invalid
as power is uninitialized. As Lukasz suggested, it must return -EINVAL when
the 'policy' is not found. So return -EINVAL to fix it.

Cc: stable@vger.kernel.org
Fixes: 4855e26bcf ("cpufreq: mediatek-hw: Add support for CPUFREQ HW")
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Suggested-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Jinjie Ruan

2024-11-07 19:38:41 +08:00

committed by

Greg Kroah-Hartman

parent e6e42c57ce

commit bc846c0be8

1 changed files with 1 additions and 1 deletions

									
										drivers/cpufreq/mediatek-cpufreq-hw.c
									
		+1
		-1
	
												View File
												
				@@ -60,7 +60,7 @@ mtk_cpufreq_get_cpu_power(unsigned long *mW,

					policy = cpufreq_cpu_get_raw(cpu_dev->id);

					if (!policy)

						return 0;

						return -EINVAL;

					data = policy->driver_data;