TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: i2c: tda1997x: Call of_node_put(ep) only once in tda1997x_parse_dt()

Browse Source 
An of_node_put(ep) call was immediately used after a return value check
for a v4l2_fwnode_endpoint_parse() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
This commit is contained in:
Markus Elfring
2024-10-03 21:38:45 +02:00
committed by Hans Verkuil
parent 223fc68d31
commit b50231ff01
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/media/i2c/tda1997x.c
+3 -4
View File
@@ -2315,11 +2315,10 @@ static int tda1997x_parse_dt(struct tda1997x_state *state)
return -EINVAL;
ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &bus_cfg);
if (ret) {
of_node_put(ep);
return ret;
}
of_node_put(ep);
if (ret)
return ret;
pdata->vidout_bus_type = bus_cfg.bus_type;
/* polarity of HS/VS/DE */