bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan()

[ Upstream commit a63db07e4e ]

If bnxt_rx_vlan() fails because the VLAN protocol ID is invalid,
the SKB is freed but we're missing the call to recycle it.  This
may cause the warning:

"page_pool_release_retry() stalled pool shutdown"

Add the missing skb_mark_for_recycle() in bnxt_rx_vlan().

Fixes: 86b05508f7 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP")
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Somnath Kotur

2025-04-28 15:58:58 -07:00

committed by

Greg Kroah-Hartman

parent 808a7304b5

commit aa15f389fc

1 changed files with 1 additions and 0 deletions

									
										drivers/net/ethernet/broadcom/bnxt/bnxt.c
									
		+1
		
												View File
												
				@@ -1986,6 +1986,7 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type,

					}

					return skb;

				vlan_err:

					skb_mark_for_recycle(skb);

					dev_kfree_skb(skb);

					return NULL;

				}