staging: gpib: Correct CamelCase for VALID enums

Adhere to Linux kernel coding style.

Reported by checkpatch

CHECK: Avoid CamelCase

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Acked-By: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250319211827.9854-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Rubin
2025-03-19 21:18:27 +00:00
committed by Greg Kroah-Hartman
parent 82184cc117
commit a8e233d074
12 changed files with 21 additions and 21 deletions
@@ -1017,7 +1017,7 @@ static int agilent_82357a_line_status(const gpib_board_t *board)
struct usb_device *usb_dev;
struct agilent_82357a_register_pairlet bus_status;
int retval;
int status = ValidALL;
int status = VALID_ALL;
if (!a_priv->bus_interface)
return -ENODEV;
+1 -1
View File
@@ -379,7 +379,7 @@ static int cb7210_accel_write(gpib_board_t *board, uint8_t *buffer, size_t lengt
static int cb7210_line_status(const gpib_board_t *board)
{
int status = ValidALL;
int status = VALID_ALL;
int bsr_bits;
struct cb7210_priv *cb_priv;
+2 -2
View File
@@ -76,7 +76,7 @@ static int check_for_command_acceptors(gpib_board_t *board)
if (lines < 0)
return lines;
if ((lines & ValidNRFD) && (lines & ValidNDAC)) {
if ((lines & VALID_NRFD) && (lines & VALID_NDAC)) {
if ((lines & BUS_NRFD) == 0 && (lines & BUS_NDAC) == 0)
return -ENOTCONN;
}
@@ -520,7 +520,7 @@ int general_ibstatus(gpib_board_t *board, const gpib_status_queue_t *device,
status &= ~TIMO;
/* get real SRQI status if we can */
if (iblines(board, &line_status) == 0) {
if ((line_status & ValidSRQ)) {
if ((line_status & VALID_SRQ)) {
if ((line_status & BUS_SRQ))
status |= SRQI;
else
+1 -1
View File
@@ -195,7 +195,7 @@ static void fluke_return_to_local(gpib_board_t *board)
static int fluke_line_status(const gpib_board_t *board)
{
int status = ValidALL;
int status = VALID_ALL;
int bsr_bits;
struct fluke_priv *e_priv;
+1 -1
View File
@@ -229,7 +229,7 @@ static void fmh_gpib_return_to_local(gpib_board_t *board)
static int fmh_gpib_line_status(const gpib_board_t *board)
{
int status = ValidALL;
int status = VALID_ALL;
int bsr_bits;
struct fmh_priv *e_priv;
struct nec7210_priv *nec_priv;
+1 -1
View File
@@ -1031,7 +1031,7 @@ static void bb_return_to_local(gpib_board_t *board)
static int bb_line_status(const gpib_board_t *board)
{
int line_status = ValidALL;
int line_status = VALID_ALL;
if (gpiod_get_value(REN) == 0)
line_status |= BUS_REN;
+1 -1
View File
@@ -27,7 +27,7 @@ MODULE_DESCRIPTION("GPIB driver for Ines iGPIB 72010");
int ines_line_status(const gpib_board_t *board)
{
int status = ValidALL;
int status = VALID_ALL;
int bcm_bits;
struct ines_priv *ines_priv;
@@ -658,7 +658,7 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)
static int usb_gpib_line_status(const gpib_board_t *board)
{
int buffer;
int line_status = ValidALL; /* all lines will be read */
int line_status = VALID_ALL; /* all lines will be read */
struct list_head *p, *q;
WQT *item;
unsigned long flags;
+1 -1
View File
@@ -1508,7 +1508,7 @@ static int ni_usb_line_status(const gpib_board_t *board)
int bytes_written = 0, bytes_read = 0;
int i = 0;
unsigned int bsr_bits;
int line_status = ValidALL;
int line_status = VALID_ALL;
// NI windows driver reads 0xd(HSSEL), 0xc (ARD0), 0x1f (BSR)
if (!ni_priv->bus_interface)
+1 -1
View File
@@ -391,7 +391,7 @@ static unsigned int update_status_nolock(gpib_board_t *board, struct tms9914_pri
int tms9914_line_status(const gpib_board_t *board, struct tms9914_priv *priv)
{
int bsr_bits;
int status = ValidALL;
int status = VALID_ALL;
bsr_bits = read_byte(priv, BSR);
+1 -1
View File
@@ -150,7 +150,7 @@ MODULE_DESCRIPTION("GPIB driver for National Instruments boards using tnt4882 or
static int tnt4882_line_status(const gpib_board_t *board)
{
int status = ValidALL;
int status = VALID_ALL;
int bcsr_bits;
struct tnt4882_priv *tnt_priv;
+9 -9
View File
@@ -106,15 +106,15 @@ enum eos_flags {
/* GPIB Bus Control Lines bit vector */
enum bus_control_line {
ValidDAV = 0x01,
ValidNDAC = 0x02,
ValidNRFD = 0x04,
ValidIFC = 0x08,
ValidREN = 0x10,
ValidSRQ = 0x20,
ValidATN = 0x40,
ValidEOI = 0x80,
ValidALL = 0xff,
VALID_DAV = 0x01,
VALID_NDAC = 0x02,
VALID_NRFD = 0x04,
VALID_IFC = 0x08,
VALID_REN = 0x10,
VALID_SRQ = 0x20,
VALID_ATN = 0x40,
VALID_EOI = 0x80,
VALID_ALL = 0xff,
BUS_DAV = 0x0100, /* DAV line status bit */
BUS_NDAC = 0x0200, /* NDAC line status bit */
BUS_NRFD = 0x0400, /* NRFD line status bit */