md: do not delete safemode_timer in mddev_suspend

The deletion of safemode_timer in mddev_suspend() is redundant and
potentially harmful now. If timer is about to be woken up but gets
deleted, 'in_sync' will remain 0 until the next write, causing array
to stay in the 'active' state instead of transitioning to 'clean'.

Commit 0d9f4f135e ("MD: Add del_timer_sync to mddev_suspend (fix
nasty panic))" introduced this deletion for dm, because if timer fired
after dm is destroyed, the resource which the timer depends on might
have been freed.

However, commit 0dd84b3193 ("md: call __md_stop_writes in md_stop")
added __md_stop_writes() to md_stop(), which is called before freeing
resource. Timer is deleted in __md_stop_writes(), and the origin issue
is resolved. Therefore, delete safemode_timer can be removed safely now.

Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240508092053.1447930-1-linan666@huaweicloud.com

This commit is contained in:

Li Nan

2024-05-08 17:20:53 +08:00

committed by

Song Liu

parent 83a7eefedc

commit a8768a1345

1 changed files with 0 additions and 1 deletions

									
										drivers/md/md.c
									
		-1
	
												View File
												
				@@ -479,7 +479,6 @@ int mddev_suspend(struct mddev *mddev, bool interruptible)

					 */

					WRITE_ONCE(mddev->suspended, mddev->suspended + 1);

					del_timer_sync(&mddev->safemode_timer);

					/* restrict memory reclaim I/O during raid array is suspend */

					mddev->noio_flag = memalloc_noio_save();