TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ALSA] Fix invalid assignment of PCI revision

Browse Source 
Fix the type of PCI revision to char from int and avoid invalid
assignment with pointer cast.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
This commit is contained in:
Takashi Iwai
2007-03-28 22:32:32 +02:00
committed by Adrian Bunk
parent 4eebc3a634
commit 8e617c8834
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/sound/ymfpci.h
+1 -1
View File
@@ -285,7 +285,7 @@ struct snd_ymfpci {
int irq;
unsigned int device_id; /* PCI device ID */
unsigned int rev; /* PCI revision */
unsigned char rev; /* PCI revision */
unsigned long reg_area_phys;
void __iomem *reg_area_virt;
struct resource *res_reg_area;
sound/pci/ca0106/ca0106.h
+1 -1
View File
@@ -590,7 +590,7 @@ struct snd_ca0106 {
struct resource *res_port;
int irq;
unsigned int revision; /* chip revision */
unsigned char revision; /* chip revision */
unsigned int serial; /* serial number */
unsigned short model; /* subsystem id */
sound/pci/ca0106/ca0106_main.c
+1 -1
View File
@@ -1260,7 +1260,7 @@ static int __devinit snd_ca0106_create(struct snd_card *card,
pci_set_master(pci);
/* read revision & serial */
pci_read_config_byte(pci, PCI_REVISION_ID, (char *)&chip->revision);
pci_read_config_byte(pci, PCI_REVISION_ID, &chip->revision);
pci_read_config_dword(pci, PCI_SUBSYSTEM_VENDOR_ID, &chip->serial);
pci_read_config_word(pci, PCI_SUBSYSTEM_ID, &chip->model);
#if 1
sound/pci/emu10k1/emu10k1x.c
+2 -2
View File
@@ -234,7 +234,7 @@ struct emu10k1x {
struct resource *res_port;
int irq;
unsigned int revision; /* chip revision */
unsigned char revision; /* chip revision */
unsigned int serial; /* serial number */
unsigned short model; /* subsystem id */
@@ -943,7 +943,7 @@ static int __devinit snd_emu10k1x_create(struct snd_card *card,
pci_set_master(pci);
/* read revision & serial */
pci_read_config_byte(pci, PCI_REVISION_ID, (char *)&chip->revision);
pci_read_config_byte(pci, PCI_REVISION_ID, &chip->revision);
pci_read_config_dword(pci, PCI_SUBSYSTEM_VENDOR_ID, &chip->serial);
pci_read_config_word(pci, PCI_SUBSYSTEM_ID, &chip->model);
snd_printk(KERN_INFO "Model %04x Rev %08x Serial %08x\n", chip->model,
sound/pci/ymfpci/ymfpci_main.c
+1 -1
View File
@@ -2261,7 +2261,7 @@ int __devinit snd_ymfpci_create(struct snd_card *card,
chip->pci = pci;
chip->irq = -1;
chip->device_id = pci->device;
pci_read_config_byte(pci, PCI_REVISION_ID, (u8 *)&chip->rev);
pci_read_config_byte(pci, PCI_REVISION_ID, &chip->rev);
chip->reg_area_phys = pci_resource_start(pci, 0);
chip->reg_area_virt = ioremap_nocache(chip->reg_area_phys, 0x8000);
pci_set_master(pci);