selftests: net: fix rps_default_mask with >32 CPUs
[ Upstream commit0719b5338a] If there is more than 32 cpus the bitmask will start to contain commas, leading to: ./rps_default_mask.sh: line 36: [: 00000000,00000000: integer expression expected Remove the commas, bash doesn't interpret leading zeroes as oct so that should be good enough. Switch to bash, Simon reports that not all shells support this type of substitution. Fixes:c12e0d5f26("self-tests: introduce self-tests for RPS default mask") Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240122195815.638997-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
938729484c
commit
8c63896d99
@@ -1,4 +1,4 @@
|
||||
#!/bin/sh
|
||||
#!/bin/bash
|
||||
# SPDX-License-Identifier: GPL-2.0
|
||||
|
||||
readonly ksft_skip=4
|
||||
@@ -33,6 +33,10 @@ chk_rps() {
|
||||
|
||||
rps_mask=$($cmd /sys/class/net/$dev_name/queues/rx-0/rps_cpus)
|
||||
printf "%-60s" "$msg"
|
||||
|
||||
# In case there is more than 32 CPUs we need to remove commas from masks
|
||||
rps_mask=${rps_mask//,}
|
||||
expected_rps_mask=${expected_rps_mask//,}
|
||||
if [ $rps_mask -eq $expected_rps_mask ]; then
|
||||
echo "[ ok ]"
|
||||
else
|
||||
|
||||
Reference in New Issue
Block a user