NTB: EPF: fix possible memory leak in pci_vntb_probe()

[ Upstream commit 956578e3d3 ]

As ntb_register_device() don't handle error of device_register(),
if ntb_register_device() returns error in pci_vntb_probe(), name of kobject
which is allocated in dev_set_name() called in device_add() is leaked.

As comment of device_add() says, it should call put_device() to drop the
reference count that was set in device_initialize()
when it fails, so the name can be freed in kobject_cleanup().

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Stable-dep-of: aebfdfe39b ("NTB: fix possible name leak in ntb_register_device()")
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

ruanjinjie

2022-11-09 17:28:52 +08:00

committed by

Sasha Levin

parent e2b6ef72b7

commit 87d306cdeb

1 changed files with 1 additions and 0 deletions

									
										drivers/pci/endpoint/functions/pci-epf-vntb.c
									
		+1
		
												View File
												
				@@ -1249,6 +1249,7 @@ static int pci_vntb_probe(struct pci_dev *pdev, const struct pci_device_id *id)

					return 0;

				err_register_dev:

					put_device(&ndev->ntb.dev);

					return -EINVAL;

				}