soc: ti: knav: Drop unnecessary check for property presence
of_property_read_u32() returns -EINVAL if a property is not present, so the preceding check for presence with of_get_property() can be dropped. This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Link: https://lore.kernel.org/r/20240731201407.1838385-2-robh@kernel.org Signed-off-by: Nishanth Menon <nm@ti.com>
This commit is contained in:
committed by
Nishanth Menon
parent
d9483b44c9
commit
8737e167dc
@@ -1104,11 +1104,6 @@ static int knav_queue_setup_regions(struct knav_device *kdev,
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!of_get_property(child, "link-index", NULL)) {
|
||||
dev_err(dev, "No link info for %s\n", region->name);
|
||||
devm_kfree(dev, region);
|
||||
continue;
|
||||
}
|
||||
ret = of_property_read_u32(child, "link-index",
|
||||
®ion->link_index);
|
||||
if (ret) {
|
||||
|
||||
Reference in New Issue
Block a user