[WATCHDOG] sc1200wdt.c pnp unregister fix.
If no devices found or invalid parameter is specified, scl200wdt_pnp_driver is left unregistered. It breaks global list of pnp drivers. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Adrian Bunk <bunk@stusta.de>
This commit is contained in:
committed by
Adrian Bunk
parent
18d16ac9bb
commit
8132c7a57a
@@ -393,7 +393,7 @@ static int __init sc1200wdt_init(void)
|
||||
if (io == -1) {
|
||||
printk(KERN_ERR PFX "io parameter must be specified\n");
|
||||
ret = -EINVAL;
|
||||
goto out_clean;
|
||||
goto out_pnp;
|
||||
}
|
||||
|
||||
#if defined CONFIG_PNP
|
||||
@@ -406,7 +406,7 @@ static int __init sc1200wdt_init(void)
|
||||
if (!request_region(io, io_len, SC1200_MODULE_NAME)) {
|
||||
printk(KERN_ERR PFX "Unable to register IO port %#x\n", io);
|
||||
ret = -EBUSY;
|
||||
goto out_clean;
|
||||
goto out_pnp;
|
||||
}
|
||||
|
||||
ret = sc1200wdt_probe();
|
||||
@@ -436,6 +436,11 @@ out_rbt:
|
||||
out_io:
|
||||
release_region(io, io_len);
|
||||
|
||||
out_pnp:
|
||||
#if defined CONFIG_PNP
|
||||
if (isapnp)
|
||||
pnp_unregister_driver(&scl200wdt_pnp_driver);
|
||||
#endif
|
||||
goto out_clean;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user