drm/amdgpu: Fix PCI device refcount leak in amdgpu_atrm_get_bios()

[ Upstream commit ca54639c77 ]

As comment of pci_get_class() says, it returns a pci_device with its
refcount increased and decreased the refcount for the input parameter
@from if it is not NULL.

If we break the loop in amdgpu_atrm_get_bios() with 'pdev' not NULL, we
need to call pci_dev_put() to decrease the refcount. Add the missing
pci_dev_put() to avoid refcount leak.

Fixes: d38ceaf99e ("drm/amdgpu: add core driver (v4)")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Xiongfeng Wang

2022-11-22 19:30:43 +08:00

committed by

Greg Kroah-Hartman

parent 3991d98a8a

commit 7c1ddf7c66

1 changed files with 1 additions and 0 deletions

									
										drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
									
		+1
		
												View File
												
				@@ -313,6 +313,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)

					if (!found)

						return false;

					pci_dev_put(pdev);

					adev->bios = kmalloc(size, GFP_KERNEL);

					if (!adev->bios) {