iio: adc: rockchip_saradc: fix information leak in triggered buffer

commit 3872459136 upstream.

The 'data' local struct is used to push data to user space from a
triggered buffer, but it does not set values for inactive channels, as
it only uses iio_for_each_active_channel() to assign new values.

Initialize the struct to zero before using it to avoid pushing
uninitialized information to userspace.

Cc: stable@vger.kernel.org
Fixes: 4e130dc7b4 ("iio: adc: rockchip_saradc: Add support iio buffers")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20241125-iio_memset_scan_holes-v1-4-0cb6e98d895c@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Bin Lan <lanbincn@qq.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Javier Carrasco

2024-11-25 22:16:12 +01:00

committed by

Greg Kroah-Hartman

parent b5c2c988cb

commit 7a07fb80ea

1 changed files with 2 additions and 0 deletions

									
										drivers/iio/adc/rockchip_saradc.c
									
		+2
		
												View File
												
				@@ -270,6 +270,8 @@ static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p)

					int ret;

					int i, j = 0;

					memset(&data, 0, sizeof(data));

					mutex_lock(&i_dev->mlock);

					for_each_set_bit(i, i_dev->active_scan_mask, i_dev->masklength) {