TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ALSA] ad1848 double free

Browse Source 
snd_ctl_add() already kfree's on error.

Coverity #956

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
This commit is contained in:
Dave Jones
2006-12-15 00:37:55 +01:00
committed by Adrian Bunk
parent 5bee6f6221
commit 79bb714771
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sound/isa/ad1848/ad1848_lib.c
+1 -3
View File
@@ -1202,10 +1202,8 @@ int snd_ad1848_add_ctl(struct snd_ad1848 *chip, const char *name, int index, int
strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
ctl->id.index = index;
ctl->private_value = value;
if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
snd_ctl_free_one(ctl);
if ((err = snd_ctl_add(chip->card, ctl)) < 0)
return err;
}
return 0;
}