iio: adc: ad7124: Disable all channels at probe time

commit 4be339af33 upstream.

When during a measurement two channels are enabled, two measurements are
done that are reported sequencially in the DATA register. As the code
triggered by reading one of the sysfs properties expects that only one
channel is enabled it only reads the first data set which might or might
not belong to the intended channel.

To prevent this situation disable all channels during probe. This fixes
a problem in practise because the reset default for channel 0 is
enabled. So all measurements before the first measurement on channel 0
(which disables channel 0 at the end) might report wrong values.

Fixes: 7b8d045e49 ("iio: adc: ad7124: allow more than 8 channels")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20241104101905.845737-2-u.kleine-koenig@baylibre.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Uwe Kleine-König

2024-11-04 11:19:04 +01:00

committed by

Greg Kroah-Hartman

parent 91dd568e3f

commit 6a96af5f30

1 changed files with 3 additions and 0 deletions

									
										drivers/iio/adc/ad7124.c
									
		+3
		
												View File
												
				@@ -923,6 +923,9 @@ static int ad7124_setup(struct ad7124_state *st)

						 * set all channels to this default value.

						 */

						ad7124_set_channel_odr(st, i, 10);

						/* Disable all channels to prevent unintended conversions. */

						ad_sd_write_reg(&st->sd, AD7124_CHANNEL(i), 2, 0);

					}

					return ret;