[PATCH] Fix speedstep-smi assembly bug in speedstep_smi_ownership
Fix bug identified by Linus Torvalds <torvalds@osdl.org>: the `out' instruction depends upon the state of memory_data[], so we need to tell gcc that before executing it. (The opcode, not gcc). Fixes http://bugzilla.kernel.org/show_bug.cgi?id=5553 Thanks to Antonio Ospite <ospite@studenti.unina.it> for testing. Cc: Dave Jones <davej@codemonkey.org.uk> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
74c34e68ec
commit
5e48e1d633
@@ -75,7 +75,9 @@ static int speedstep_smi_ownership (void)
|
||||
__asm__ __volatile__(
|
||||
"out %%al, (%%dx)\n"
|
||||
: "=D" (result)
|
||||
: "a" (command), "b" (function), "c" (0), "d" (smi_port), "D" (0), "S" (magic)
|
||||
: "a" (command), "b" (function), "c" (0), "d" (smi_port),
|
||||
"D" (0), "S" (magic)
|
||||
: "memory"
|
||||
);
|
||||
|
||||
dprintk("result is %x\n", result);
|
||||
|
||||
Reference in New Issue
Block a user