media: uapi/linux/cec.h: cec_msg_set_reply_to: zero flags
commit599f689905upstream. The cec_msg_set_reply_to() helper function never zeroed the struct cec_msg flags field, this can cause unexpected behavior if flags was uninitialized to begin with. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Fixes:0dbacebede("[media] cec: move the CEC framework out of staging and to media") Cc: <stable@vger.kernel.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
862ab6b7c7
commit
5c78477386
@@ -132,6 +132,8 @@ static inline void cec_msg_init(struct cec_msg *msg,
|
||||
* Set the msg destination to the orig initiator and the msg initiator to the
|
||||
* orig destination. Note that msg and orig may be the same pointer, in which
|
||||
* case the change is done in place.
|
||||
*
|
||||
* It also zeroes the reply, timeout and flags fields.
|
||||
*/
|
||||
static inline void cec_msg_set_reply_to(struct cec_msg *msg,
|
||||
struct cec_msg *orig)
|
||||
@@ -139,7 +141,9 @@ static inline void cec_msg_set_reply_to(struct cec_msg *msg,
|
||||
/* The destination becomes the initiator and vice versa */
|
||||
msg->msg[0] = (cec_msg_destination(orig) << 4) |
|
||||
cec_msg_initiator(orig);
|
||||
msg->reply = msg->timeout = 0;
|
||||
msg->reply = 0;
|
||||
msg->timeout = 0;
|
||||
msg->flags = 0;
|
||||
}
|
||||
|
||||
/* cec_msg flags field */
|
||||
|
||||
Reference in New Issue
Block a user