perf test: Remove atomics from test_loop to avoid test failures
[ Upstream commit72b4ca7e99] The current use of atomics can lead to test failures, as tests (such as tests/shell/record.sh) search for samples with "test_loop" as the top-most stack frame, but find frames related to the atomic operation (e.g. __aarch64_ldadd4_relax). This change simply removes the "count" variable, as it is not necessary. Fixes:1962ab6f6e("perf test workload thloop: Make count increments atomic") Reviewed-by: James Clark <james.clark@arm.com> Signed-off-by: Nick Forrington <nick.forrington@arm.com> Acked-by: Leo Yan <leo.yan@linaro.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20231102162225.50028-1-nick.forrington@arm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
1cf24d70d7
commit
59fcfb7617
@@ -7,7 +7,6 @@
|
||||
#include "../tests.h"
|
||||
|
||||
static volatile sig_atomic_t done;
|
||||
static volatile unsigned count;
|
||||
|
||||
/* We want to check this symbol in perf report */
|
||||
noinline void test_loop(void);
|
||||
@@ -19,8 +18,7 @@ static void sighandler(int sig __maybe_unused)
|
||||
|
||||
noinline void test_loop(void)
|
||||
{
|
||||
while (!done)
|
||||
__atomic_fetch_add(&count, 1, __ATOMIC_RELAXED);
|
||||
while (!done);
|
||||
}
|
||||
|
||||
static void *thfunc(void *arg)
|
||||
|
||||
Reference in New Issue
Block a user