PCI: j721e: Fix j721e_pcie_probe() error path

[ Upstream commit 496bb18483 ]

If an error occurs after a successful cdns_pcie_init_phy() call, it must be
undone by a cdns_pcie_disable_phy() call, as already done above and below.

Update the goto to branch at the correct place of the error handling path.

Link: https://lore.kernel.org/r/db477b0cb444891a17c4bb424467667dc30d0bab.1624794264.git.christophe.jaillet@wanadoo.fr
Fixes: 49e0efdce7 ("PCI: j721e: Add support to provide refclk to PCIe connector")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Christophe JAILLET

2021-06-27 13:46:24 +02:00

committed by

Greg Kroah-Hartman

parent 19c65258dd

commit 4e7af8a90a

1 changed files with 1 additions and 1 deletions

									
										drivers/pci/controller/cadence/pci-j721e.c
									
		+1
		-1
	
												View File
												
				@@ -474,7 +474,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)

						ret = clk_prepare_enable(clk);

						if (ret) {

							dev_err(dev, "failed to enable pcie_refclk\n");

							goto err_get_sync;

							goto err_pcie_setup;

						}

						pcie->refclk = clk;