TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] NTFS: Critical bug fix (affects MIPS and possibly others)

Browse Source 
It fixes a crash in NTFS on architectures where flush_dcache_page()
is a real function.  I never noticed this as all my testing is done on
i386 where flush_dcache_page() is NULL.

http://bugzilla.kernel.org/show_bug.cgi?id=6700

Many thanks to Pauline Ng for the detailed bug report and analysis!

Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
This commit is contained in:
Anton Altaparmakov
2006-06-20 00:29:41 -07:00
committed by Chris Wright
parent bb2f2dbc93
commit 40b61cc4d9
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/ntfs/file.c
+7 -6
View File
@@ -1489,14 +1489,15 @@ static inline void ntfs_flush_dcache_pages(struct page **pages,
unsigned nr_pages)
{
BUG_ON(!nr_pages);
/*
* Warning: Do not do the decrement at the same time as the call to
* flush_dcache_page() because it is a NULL macro on i386 and hence the
* decrement never happens so the loop never terminates.
*/
do {
/*
* Warning: Do not do the decrement at the same time as the
* call because flush_dcache_page() is a NULL macro on i386
* and hence the decrement never happens.
*/
--nr_pages;
flush_dcache_page(pages[nr_pages]);
} while (--nr_pages > 0);
} while (nr_pages > 0);
}
/**