mmc: mxcmmc: fix return value check of mmc_add_host()

[ Upstream commit cde600af7b ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host().

Fixes: d96be879ff ("mmc: Add a MX2/MX3 specific SDHC driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-4-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Yang Yingliang

2022-11-01 14:30:17 +08:00

committed by

Greg Kroah-Hartman

parent 7c3b301ca8

commit 3904eb97bb

1 changed files with 3 additions and 1 deletions

									
										drivers/mmc/host/mxcmmc.c
									
		+3
		-1
	
												View File
												
				@@ -1167,7 +1167,9 @@ static int mxcmci_probe(struct platform_device *pdev)

					timer_setup(&host->watchdog, mxcmci_watchdog, 0);

					mmc_add_host(mmc);

					ret = mmc_add_host(mmc);

					if (ret)

						goto out_free_dma;

					return 0;