serial: 8250: omap: Cleanup on error in request_irq
If devm_request_irq fails, the code does not cleanup many things that
were setup before. Instead of directly returning ret we should jump to
err.
Fixes: fef4f60031 ("serial: 8250: omap: Fix life cycle issues for interrupt handlers")
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20240807141227.1093006-4-msp@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
704c2c361e
commit
35e648a160
@@ -1587,7 +1587,7 @@ static int omap8250_probe(struct platform_device *pdev)
|
||||
ret = devm_request_irq(&pdev->dev, up.port.irq, omap8250_irq, 0,
|
||||
dev_name(&pdev->dev), priv);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
goto err;
|
||||
|
||||
priv->wakeirq = irq_of_parse_and_map(np, 1);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user