[PATCH] BNX2: Block MII access when ifdown.
The device may be in D3hot state and should not allow MII register access. Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
This commit is contained in:
committed by
Chris Wright
parent
2503fa413e
commit
2a0167b2db
@@ -5564,6 +5564,9 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
|
||||
case SIOCGMIIREG: {
|
||||
u32 mii_regval;
|
||||
|
||||
if (!netif_running(dev))
|
||||
return -EAGAIN;
|
||||
|
||||
spin_lock_bh(&bp->phy_lock);
|
||||
err = bnx2_read_phy(bp, data->reg_num & 0x1f, &mii_regval);
|
||||
spin_unlock_bh(&bp->phy_lock);
|
||||
@@ -5577,6 +5580,9 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
|
||||
if (!capable(CAP_NET_ADMIN))
|
||||
return -EPERM;
|
||||
|
||||
if (!netif_running(dev))
|
||||
return -EAGAIN;
|
||||
|
||||
spin_lock_bh(&bp->phy_lock);
|
||||
err = bnx2_write_phy(bp, data->reg_num & 0x1f, data->val_in);
|
||||
spin_unlock_bh(&bp->phy_lock);
|
||||
|
||||
Reference in New Issue
Block a user