TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rtc: rockchip: fix the rtc suspend crash

Browse Source 
In some special products, after rtc probe, The system quickly goes to
sleep before the calibration function of delay_work is executed. In rtc
suspend will clamp rtc. In the off process, if delay_work is executed,
the system will crash.
Added calibration judgments to turn off delay_work when rtc suspend.

Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
Change-Id: Ib212eabd18c27ddeff5c50e5b8ac0444a2cafc23
This commit is contained in:
Elaine Zhang
2023-11-08 11:30:41 +08:00
committed by Tao Huang
parent 8cfed66d7f
commit 1aef70a303
1 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/rtc/rtc-rockchip.c
+29 -1
View File
@@ -555,6 +555,31 @@ static void rockchip_rtc_compensation_delay_work(struct work_struct *work)
return;
}
static bool rockchip_rtc_is_trimed(struct rockchip_rtc *rtc)
{
int ret, comp_done;
ret = regmap_read(rtc->regmap, RTC_CTRL, &comp_done);
if (ret) {
pr_err("%s: Failed to read RTC_CTRL: %d\n", __func__, ret);
return false;
}
return (comp_done & CLK32K_COMP_EN) == CLK32K_COMP_EN;
}
static void rockchip_rtc_trim_start(struct rockchip_rtc *rtc)
{
if (!rockchip_rtc_is_trimed(rtc))
queue_delayed_work(system_long_wq, &rtc->trim_work,
msecs_to_jiffies(5000));
}
static void __maybe_unused rockchip_rtc_trim_close(struct rockchip_rtc *rtc)
{
if (!rockchip_rtc_is_trimed(rtc))
cancel_delayed_work_sync(&rtc->trim_work);
}
/* Enable the alarm if it should be enabled (in case it was disabled to
* prevent use as a wake source).
*/
@@ -568,6 +593,8 @@ static int rockchip_rtc_suspend(struct device *dev)
if (device_may_wakeup(dev))
enable_irq_wake(rtc->irq);
rockchip_rtc_trim_close(rtc);
if (rtc->grf) {
switch (rtc->mode) {
case ROCKCHIP_RV1106_RTC:
@@ -610,6 +637,7 @@ static int rockchip_rtc_resume(struct device *dev)
dev_err(dev, "Cannot enable clock.\n");
return ret;
}
rockchip_rtc_trim_start(rtc);
return 0;
}
@@ -761,7 +789,7 @@ static int rockchip_rtc_probe(struct platform_device *pdev)
rtc->irq);
INIT_DELAYED_WORK(&rtc->trim_work, rockchip_rtc_compensation_delay_work);
queue_delayed_work(system_long_wq, &rtc->trim_work, 3000);
rockchip_rtc_trim_start(rtc);
return rtc_register_device(rtc->rtc);
}