selftests: ktap_helpers: Fix uninitialized variable

[ Upstream commit 3e707b07f5 ]

__ktap_test() may be called without the optional third argument which is
an issue for scripts using `set -u` to detect uninitialized variables
and potential bugs.

Fix this optional "directive" argument by either using the third
argument or an empty string.

This is required for the next commit to properly test script execution
control.

Cc: Kees Cook <kees@kernel.org>
Cc: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Fixes: 14571ab1ad ("kselftest: Add new test for detecting unprobed Devicetree devices")
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Link: https://lore.kernel.org/r/20241212174223.389435-7-mic@digikod.net
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

Mickaël Salaün

2024-12-12 18:42:21 +01:00

committed by

Greg Kroah-Hartman

parent 9096ba8b9b

commit 07fb72fc9b

1 changed files with 1 additions and 1 deletions

									
										tools/testing/selftests/kselftest/ktap_helpers.sh
									
		+1
		-1
	
												View File
												
				@@ -40,7 +40,7 @@ ktap_skip_all() {

				__ktap_test() {

					result="$1"

					description="$2"

					directive="$3" # optional

					directive="${3:-}" # optional

					local directive_str=

					[ ! -z "$directive" ] && directive_str="# $directive"