Christophe JAILLET 432a06b331 perf pmu: Fix a potential memory leak in perf_pmu__lookup() ...

[ Upstream commit ef5de1613d ]

The commit in Fixes has reordered some code, but missed an error handling
path.

'goto err' now, in order to avoid a memory leak in case of error.

Fixes: f63a536f03 ("perf pmu: Merge JSON events with sysfs at load time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Ian Rogers <irogers@google.com>
Cc: kernel-janitors@vger.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/9538b2b634894c33168dfe9d848d4df31fd4d801.1693085544.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-03-26 18:17:14 -04:00

..

arm-spe-decoder

…

bpf_skel

perf lock contention: Use per-cpu array map for spinlocks

2023-10-25 10:02:55 -07:00

cs-etm-decoder

…

hisi-ptt-decoder

…

include

tools headers: Update the copy of x86's mem{cpy,set}_64.S used in 'perf bench'

2024-01-30 11:31:15 -03:00

intel-pt-decoder

perf intel-pt: Prefer get_unaligned_le64 to memcpy_le64

2023-10-17 12:40:50 -07:00

libunwind

perf unwind: Use perf_arch_reg_{ip|sp}() to substitute macros

2023-08-16 08:48:06 -03:00

perf-regs-arch

perf parse-regs: Introduce functions perf_arch_reg_{ip|sp}()

2023-08-16 08:46:45 -03:00

scripting-engines

perf script perl: Fail check on dynamic allocation

2023-11-27 10:21:27 -03:00

addr_location.c

…

addr_location.h

…

affinity.c

…

affinity.h

…

amd-sample-raw.c

perf script ibs: Remove unused include

2023-08-23 08:41:52 -03:00

annotate-data.c

perf annotate: Add --type-stat option for debugging

2023-12-23 22:40:13 -03:00

annotate-data.h

perf annotate: Add --type-stat option for debugging

2023-12-23 22:40:13 -03:00

annotate.c

perf annotate: Add --insn-stat option for debugging

2023-12-23 22:40:17 -03:00

annotate.h

perf annotate: Add --insn-stat option for debugging

2023-12-23 22:40:17 -03:00

archinsn.h

…

arm64-frame-pointer-unwind-support.c

…

arm64-frame-pointer-unwind-support.h

…

arm-spe.c

…

arm-spe.h

perf pmu: Lazily compute default config

2023-10-17 12:40:50 -07:00

auxtrace.c

libperf cpumap: Rename perf_cpu_map__empty() to perf_cpu_map__has_any_cpu_or_is_empty()

2023-12-12 14:55:13 -03:00

auxtrace.h

perf auxtrace: Add 'T' itrace option for timestamp trace

2023-11-27 10:21:27 -03:00

block-info.c

perf ui/browser/annotate: Use global annotation_options

2023-12-07 17:18:06 -03:00

block-info.h

perf ui/browser/annotate: Use global annotation_options

2023-12-07 17:18:06 -03:00

block-range.c

perf annotate: Move max_coverage from 'struct annotation' to 'struct annotated_branch'

2023-11-09 13:49:33 -03:00

block-range.h

…

bpf_counter_cgroup.c

…

bpf_counter.c

libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()

2023-12-12 14:55:13 -03:00

bpf_counter.h

…

bpf_ftrace.c

…

bpf_kwork_top.c

perf kwork top: Simplify bool conversion

2023-09-18 15:38:46 -07:00

bpf_kwork.c

…

bpf_lock_contention.c

perf maps: Add maps__load_first()

2023-12-20 14:56:10 -03:00

bpf_map.c

…

bpf_map.h

…

bpf_off_cpu.c

perf offcpu: Add missed btf_free

2023-10-25 13:38:33 -07:00

bpf-event.c

perf env: Avoid recursively taking env->bpf_progs.lock

2024-01-03 17:54:54 -03:00

bpf-event.h

perf env: Avoid recursively taking env->bpf_progs.lock

2024-01-03 17:54:54 -03:00

bpf-filter.c

perf bpf-filter: Fix sample flag check with ||

2023-08-15 16:41:48 -03:00

bpf-filter.h

…

bpf-filter.l

…

bpf-filter.y

perf bpf-filter: Add YYDEBUG

2023-09-12 17:50:36 -03:00

bpf-prologue.h

…

bpf-utils.c

…

bpf-utils.h

…

branch.c

perf callchain: Make display use of branch_type_stat const

2023-10-25 13:38:50 -07:00

branch.h

perf callchain: Make display use of branch_type_stat const

2023-10-25 13:38:50 -07:00

Build

perf annotate-data: Add find_data_type() to get type from memory access

2023-12-23 22:39:18 -03:00

build-id.c

perf build-id: Simplify build_id_cache__cachedir()

2023-08-25 10:24:10 -03:00

build-id.h

…

cache.h

…

cacheline.c

…

cacheline.h

…

call-path.c

…

call-path.h

…

callchain.c

perf callchain: Fix spelling mistake "statisitcs" -> "statistics"

2023-10-27 19:26:13 -07:00

callchain.h

perf callchain: Minor layout changes to callchain_list

2023-10-25 13:39:32 -07:00

cap.c

…

cap.h

…

cgroup.c

perf lock contention: Add -G/--cgroup-filter option

2023-09-12 17:32:00 -03:00

cgroup.h

perf lock contention: Add -G/--cgroup-filter option

2023-09-12 17:32:00 -03:00

clockid.c

…

clockid.h

…

cloexec.c

…

cloexec.h

…

color_config.c

…

color.c

…

color.h

…

comm.c

…

comm.h

…

compress.h

perf mmap: Lazily initialize zstd streams to save memory when not using it

2023-11-28 14:25:06 -03:00

config.c

perf parse-events: Remove BPF event support

2023-08-15 16:41:48 -03:00

config.h

…

copyfile.c

…

copyfile.h

…

counts.c

…

counts.h

…

cpu-set-sched.h

…

cpumap.c

libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()

2023-12-12 14:55:13 -03:00

cpumap.h

…

cputopo.c

libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()

2023-12-12 14:55:13 -03:00

cputopo.h

…

cs-etm-base.c

…

cs-etm.c

perf cs-etm: Enable itrace option 'T'

2023-11-27 10:21:27 -03:00

cs-etm.h

perf pmu: Lazily compute default config

2023-10-17 12:40:50 -07:00

data-convert-bt.c

…

data-convert-json.c

…

data-convert.h

…

data.c

perf record: Check conflict between '--timestamp-filename' option and pipe mode before recording

2024-03-26 18:17:01 -04:00

data.h

…

db-export.c

perf db-export: Fix missing reference count get in call_path_from_sample()

2024-01-04 18:29:17 -03:00

db-export.h

…

debug.c

perf debug: Expose debug file

2023-12-20 14:53:20 -03:00

debug.h

perf debug: Expose debug file

2023-12-20 14:53:20 -03:00

debuginfo.c

perf tools: Add util/debuginfo.[ch] files

2023-11-10 09:03:54 -03:00

debuginfo.h

perf tools: Add util/debuginfo.[ch] files

2023-11-10 09:03:54 -03:00

demangle-cxx.cpp

…

demangle-cxx.h

…

demangle-java.c

…

demangle-java.h

…

demangle-ocaml.c

…

demangle-ocaml.h

…

demangle-rust.c

…

demangle-rust.h

…

dlfilter.c

Merge tag 'perf-tools-fixes-for-v6.6-2-2023-10-20' into perf-tools-next

2023-10-30 13:46:27 -07:00

dlfilter.h

…

dso.c

perf annotate-data: Add dso->data_types tree

2023-12-23 22:39:42 -03:00

dso.h

perf annotate-data: Add dso->data_types tree

2023-12-23 22:39:42 -03:00

dsos.c

…

dsos.h

…

dump-insn.c

…

dump-insn.h

…

dwarf-aux.c

perf dwarf-aux: Factor out die_get_typename_from_type()

2023-12-23 10:42:50 -03:00

dwarf-aux.h

perf dwarf-aux: Factor out die_get_typename_from_type()

2023-12-23 10:42:50 -03:00

dwarf-regs.c

perf dwarf-regs: Add get_dwarf_regnum()

2023-12-23 10:56:05 -03:00

env.c

perf env: Avoid recursively taking env->bpf_progs.lock

2024-01-03 17:54:54 -03:00

env.h

perf env: Avoid recursively taking env->bpf_progs.lock

2024-01-03 17:54:54 -03:00

event.c

perf record: Lazy load kernel symbols

2023-11-09 13:49:32 -03:00

event.h

perf symbols: Add kallsyms__get_symbol_start()

2023-07-28 19:01:16 -03:00

events_stats.h

…

evlist.c

perf evlist: Fix evlist__new_default() for > 1 core PMU

2024-01-30 11:40:28 -03:00

evlist.h

perf top: Uniform the event name for the hybrid machine

2023-12-14 19:13:10 -03:00

evsel_config.h

…

evsel_fprintf.c

…

evsel_fprintf.h

…

evsel.c

perf evsel: Fix duplicate initialization of data->id in evsel__parse_sample()

2024-03-26 18:17:02 -04:00

evsel.h

perf evsel: Fallback to "task-clock" when not system wide

2023-12-06 09:45:58 -03:00

evswitch.c

…

evswitch.h

…

expr.c

perf expr: Fix "has_event" function for metric style events

2024-03-26 18:17:05 -04:00

expr.h

perf jevents: Add a new expression builtin strcmp_cpuid_str()

2023-08-17 14:12:14 -03:00

expr.l

perf jevents: Add a new expression builtin strcmp_cpuid_str()

2023-08-17 14:12:14 -03:00

expr.y

perf expr: Make YYDEBUG dependent on doing a debug build

2023-09-12 17:46:50 -03:00

find-map.c

…

fncache.c

…

fncache.h

…

ftrace.h

…

genelf_debug.c

…

genelf.c

perf genelf: Set ELF program header addresses properly

2023-12-14 18:56:34 -03:00

genelf.h

…

generate-cmdlist.sh

…

get_current_dir_name.c

…

get_current_dir_name.h

…

hashmap.c

…

hashmap.h

perf tools: Update copy of libbpf's hashmap.c

2023-09-11 10:31:02 -03:00

header.c

perf env: Avoid recursively taking env->bpf_progs.lock

2024-01-03 17:54:54 -03:00

header.h

…

help-unknown-cmd.c

…

help-unknown-cmd.h

…

hisi-ptt.c

perf hisi-ptt: Fix one memory leakage in hisi_ptt_process_auxtrace_event()

2023-12-13 13:56:09 -03:00

hisi-ptt.h

…

hist.c

perf tools: Fix calloc() arguments to address error introduced in gcc-14

2024-01-26 12:56:01 -03:00

hist.h

perf report: Add 'symoff' sort key

2023-12-23 22:39:42 -03:00

intel-bts.c

…

intel-bts.h

…

intel-pt.c

perf intel-pt: Fix async branch flags

2023-09-29 23:59:08 -07:00

intel-pt.h

perf pmu: Lazily compute default config

2023-10-17 12:40:50 -07:00

intlist.c

…

intlist.h

…

iostat.c

…

iostat.h

…

jit.h

…

jitdump.c

perf jitdump: Avoid memory leak

2023-10-12 10:01:56 -07:00

jitdump.h

…

kvm-stat.h

…

kwork.h

perf kwork top: Implements BPF-based cpu usage statistics

2023-09-12 17:31:59 -03:00

levenshtein.c

…

levenshtein.h

…

lock-contention.h

perf lock contention: Add -G/--cgroup-filter option

2023-09-12 17:32:00 -03:00

lzma.c

perf lzma: Convert some pr_err() to pr_debug() as callers already use pr_debug()

2023-08-22 16:53:32 -03:00

machine.c

perf maps: Add find next entry to give entry after the given map

2023-12-20 15:02:02 -03:00

machine.h

perf threads: Remove unused dead thread list

2023-10-25 13:38:09 -07:00

map_symbol.c

perf mem_info: Add and use map_symbol__exit and addr_map_symbol__exit

2023-10-25 13:39:58 -07:00

map_symbol.h

perf mem_info: Add and use map_symbol__exit and addr_map_symbol__exit

2023-10-25 13:39:58 -07:00

map.c

perf map: Simplify map_ip/unmap_ip and make 'struct map' smaller

2023-12-06 13:01:42 -03:00

map.h

perf map: Improve map/unmap parameter names

2023-12-18 21:34:51 -03:00

maps.c

perf maps: Fix up overlaps during fixup_end

2023-12-20 15:02:36 -03:00

maps.h

perf maps: Reduce scope of map_rb_node and maps internals

2023-12-20 15:02:17 -03:00

mem2node.c

…

mem2node.h

…

mem-events.c

perf mem: Fix error on hybrid related to availability of mem event in a PMU

2023-12-05 15:48:52 -03:00

mem-events.h

perf pmu: Remove logic for PMU name being NULL

2023-08-25 10:22:16 -03:00

memswap.c

…

memswap.h

…

metricgroup.c

perf tools: Fix calloc() arguments to address error introduced in gcc-14

2024-01-26 12:56:01 -03:00

metricgroup.h

…

mmap.c

perf mmap: Lazily initialize zstd streams to save memory when not using it

2023-11-28 14:25:06 -03:00

mmap.h

perf mmap: Lazily initialize zstd streams to save memory when not using it

2023-11-28 14:25:06 -03:00

mutex.c

…

mutex.h

…

namespaces.c

…

namespaces.h

…

off_cpu.h

…

ordered-events.c

…

ordered-events.h

…

parse-branch-options.c

perf tools: Add branch counter knob

2023-11-09 13:47:50 -03:00

parse-branch-options.h

…

parse-events.c

perf parse-events: Make legacy events lower priority than sysfs/JSON

2023-11-27 10:21:27 -03:00

parse-events.h

perf parse-events: Introduce 'struct parse_events_terms'

2023-09-11 10:26:36 -03:00

parse-events.l

perf parse-events: Avoid erange from hex numbers

2023-10-12 10:01:55 -07:00

parse-events.y

perf parse-events: Fix for term values that are raw events

2023-10-12 10:01:55 -07:00

parse-regs-options.c

…

parse-regs-options.h

…

parse-sublevel-options.c

…

parse-sublevel-options.h

…

path.c

…

path.h

…

perf_api_probe.c

libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()

2023-12-12 14:55:13 -03:00

perf_api_probe.h

…

perf_event_attr_fprintf.c

perf tools: Add branch counter knob

2023-11-09 13:47:50 -03:00

perf_regs.c

perf parse-regs: Remove PERF_REGS_{MAX|MASK} from common code

2023-08-16 08:49:10 -03:00

perf_regs.h

perf parse-regs: Move out arch specific header from util/perf_regs.h

2023-08-16 08:52:45 -03:00

perf-hooks-list.h

…

perf-hooks.c

…

perf-hooks.h

…

PERF-VERSION-GEN

…

pfm.c

perf list pfm: Retry supported test with exclude_kernel

2023-09-12 17:32:00 -03:00

pfm.h

…

pmu.c

perf pmu: Fix a potential memory leak in perf_pmu__lookup()

2024-03-26 18:17:14 -04:00

pmu.h

perf parse-events: Make legacy events lower priority than sysfs/JSON

2023-11-27 10:21:27 -03:00

pmu.l

…

pmu.y

perf pmu: Add YYDEBUG

2023-09-12 17:47:00 -03:00

pmus.c

perf pmus: Make PMU alias name loading lazy

2023-09-29 22:50:42 -07:00

pmus.h

perf pmus: Skip duplicate PMUs and don't print list suffix by default

2023-08-29 14:16:14 -03:00

print_binary.c

…

print_binary.h

…

print-events.c

perf print-events: make is_event_supported() more robust

2024-03-26 18:17:11 -04:00

print-events.h

perf pmus: Skip duplicate PMUs and don't print list suffix by default

2023-08-29 14:16:14 -03:00

probe-event.c

perf probe-event: Use function to add missing maps lock

2023-12-18 21:35:07 -03:00

probe-event.h

perf probe: Make synthesize_perf_probe_point() private to probe-event.c

2023-08-07 16:40:29 -03:00

probe-file.c

…

probe-file.h

…

probe-finder.c

perf probe: Convert to check dwarf_getcfi feature

2023-11-10 09:04:21 -03:00

probe-finder.h

perf tools: Add util/debuginfo.[ch] files

2023-11-10 09:03:54 -03:00

pstack.c

…

pstack.h

…

python-ext-sources

perf python: Fix binding linkage due to rename and move of evsel__increase_rlimit()

2023-10-27 19:23:52 -07:00

python.c

perf pmu: Const-ify file APIs

2023-10-17 12:40:50 -07:00

rb_resort.h

…

rblist.c

…

rblist.h

…

record.c

libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()

2023-12-12 14:55:13 -03:00

record.h

…

rlimit.c

perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile

2023-10-25 10:02:11 -07:00

rlimit.h

perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile

2023-10-25 10:02:11 -07:00

rwsem.c

perf rwsem: Add debug mode that uses a mutex

2023-10-25 13:35:35 -07:00

rwsem.h

perf rwsem: Add debug mode that uses a mutex

2023-10-25 13:35:35 -07:00

s390-cpumcf-kernel.h

perf report: Add s390 raw data interpretation for PAI counters

2023-11-15 12:51:53 -05:00

s390-cpumsf-kernel.h

…

s390-cpumsf.c

…

s390-cpumsf.h

…

s390-sample-raw.c

perf report: Remove warning on missing raw data for s390

2023-11-27 15:38:37 -03:00

sample-raw.c

…

sample-raw.h

…

sample.h

perf tools: Add branch counter knob

2023-11-09 13:47:50 -03:00

session.c

perf machine thread: Remove exited threads by default

2023-11-09 13:49:32 -03:00

session.h

…

setns.c

…

setup.py

perf python: Cope with declarations after statements found in Python.h

2023-08-03 17:01:28 -03:00

sharded_mutex.c

…

sharded_mutex.h

…

sideband_evlist.c

…

smt.c

…

smt.h

…

sort.c

perf annotate: Add --data-type option

2023-12-23 22:39:43 -03:00

sort.h

perf report: Add 'symoff' sort key

2023-12-23 22:39:42 -03:00

spark.c

…

spark.h

…

srccode.c

…

srccode.h

…

srcline.c

perf srcline: Add missed addr2line closes

2024-03-26 18:17:04 -04:00

srcline.h

…

stat-display.c

perf stat: Avoid metric-only segv

2024-03-26 18:17:06 -04:00

stat-shadow.c

perf metric: Don't remove scale from counts

2024-03-26 18:17:06 -04:00

stat.c

perf stat: Combine the -A/--no-aggr and --no-merge options

2023-12-14 18:24:38 -03:00

stat.h

perf stat: Combine the -A/--no-aggr and --no-merge options

2023-12-14 18:24:38 -03:00

strbuf.c

…

strbuf.h

…

stream.c

…

stream.h

…

strfilter.c

…

strfilter.h

…

string2.h

perf util: Add a function for replacing characters in a string

2023-09-12 17:32:00 -03:00

string.c

perf util: Add a function for replacing characters in a string

2023-09-12 17:32:00 -03:00

strlist.c

…

strlist.h

…

svghelper.c

perf svghelper: Avoid memory leak

2023-10-12 10:01:56 -07:00

svghelper.h

…

symbol_conf.h

perf annotate: Add --data-type option

2023-12-23 22:39:43 -03:00

symbol_fprintf.c

…

symbol-elf.c

perf map: Simplify map_ip/unmap_ip and make 'struct map' smaller

2023-12-06 13:01:42 -03:00

symbol-minimal.c

perf symbols: Parse NOTE segments until the build id is found

2023-12-06 09:46:15 -03:00

symbol.c

perf maps: Add remove maps function to remove a map based on callback

2023-12-20 14:51:44 -03:00

symbol.h

perf maps: Move symbol maps functions to maps.c

2023-12-06 13:01:46 -03:00

symsrc.h

…

synthetic-events.c

perf tools: Fix calloc() arguments to address error introduced in gcc-14

2024-01-26 12:56:01 -03:00

synthetic-events.h

…

syscalltbl.c

…

syscalltbl.h

…

target.c

…

target.h

…

term.c

…

term.h

…

thread_map.c

perf thread_map: Free strlist on normal path in thread_map__new_by_tid_str()

2024-03-26 18:17:04 -04:00

thread_map.h

…

thread-stack.c

x86/retpoline,kprobes: Skip optprobe check for indirect jumps with retpolines and IBT

2023-08-14 11:46:51 +02:00

thread-stack.h

…

thread.c

perf maps: Rename clone to copy from

2023-12-20 14:55:30 -03:00

thread.h

perf machine thread: Remove exited threads by default

2023-11-09 13:49:32 -03:00

time-utils.c

…

time-utils.h

…

tool.h

…

top.c

perf top: Avoid repeated function calls to perf_cpu_map__nr().

2023-12-18 21:34:39 -03:00

top.h

perf top: Convert to the global annotation_options

2023-12-07 16:47:55 -03:00

topdown.c

…

topdown.h

…

trace-event-info.c

perf trace-event-info: Avoid passing NULL value to closedir

2023-10-12 10:01:57 -07:00

trace-event-parse.c

…

trace-event-read.c

…

trace-event-scripting.c

…

trace-event.c

…

trace-event.h

…

tracepoint.c

…

tracepoint.h

…

trigger.h

…

tsc.c

…

tsc.h

…

units.c

…

units.h

…

unwind-libdw.c

perf unwind-libdw: Handle JIT-generated DSOs properly

2023-12-14 19:08:48 -03:00

unwind-libdw.h

…

unwind-libunwind-local.c

perf unwind: Use function to add missing maps lock

2023-12-20 14:41:29 -03:00

unwind-libunwind.c

…

unwind.h

perf unwind: Use perf_arch_reg_{ip|sp}() to substitute macros

2023-08-16 08:48:06 -03:00

usage.c

…

util.c

…

util.h

…

values.c

…

values.h

…

vdso.c

perf vdso: Use function to add missing maps lock

2023-12-20 14:49:11 -03:00

vdso.h

…

zlib.c

…

zstd.c

perf mmap: Lazily initialize zstd streams to save memory when not using it

2023-11-28 14:25:06 -03:00