Jan Kara 352c728653 ext4: Fix deadlock during directory rename ...

[ Upstream commit 3c92792da8 ]

As lockdep properly warns, we should not be locking i_rwsem while having
transactions started as the proper lock ordering used by all directory
handling operations is i_rwsem -> transaction start. Fix the lock
ordering by moving the locking of the directory earlier in
ext4_rename().

Reported-by: syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com
Fixes: 0813299c58 ("ext4: Fix possible corruption when moving a directory")
Link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230301141004.15087-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-03-17 08:58:00 +01:00

..

.kunitconfig

…

acl.c

fs: pass dentry to set acl method

2022-10-19 12:55:42 +02:00

acl.h

fs: pass dentry to set acl method

2022-10-19 12:55:42 +02:00

balloc.c

…

bitmap.c

…

block_validity.c

…

crypto.c

…

dir.c

…

ext4_extents.h

…

ext4_jbd2.c

ext4: split ext4_journal_start trace for debug

2022-12-01 10:46:54 -05:00

ext4_jbd2.h

ext4: split ext4_journal_start trace for debug

2022-12-01 10:46:54 -05:00

ext4.h

ext4: fix incorrect options show of original mount_opt and extend mount_opt2

2023-03-11 13:50:33 +01:00

extents_status.c

ext4: fix reserved cluster accounting in __es_remove_extent()

2022-12-09 00:58:04 -05:00

extents_status.h

…

extents.c

ext4: fix delayed allocation bug in ext4_clu_mapped for bigalloc + inline

2022-12-08 21:49:25 -05:00

fast_commit.c

ext4: use ext4_fc_tl_mem in fast-commit replay path

2023-03-11 13:50:27 +01:00

fast_commit.h

ext4: add missing validation of fast-commit record lengths

2022-12-08 21:49:24 -05:00

file.c

fs: rename current get acl method

2022-10-20 10:13:27 +02:00

fsmap.c

ext4: fix another off-by-one fsmap error on 1k block filesystems

2023-03-17 08:57:48 +01:00

fsmap.h

…

fsync.c

…

hash.c

…

ialloc.c

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2022-12-12 19:56:37 -08:00

indirect.c

ext4: fix error code return to user-space in ext4_get_branch()

2022-12-08 21:49:24 -05:00

inline.c

ext4: move where set the MAY_INLINE_DATA flag is set

2023-03-17 08:57:48 +01:00

inode-test.c

…

inode.c

ext4: move where set the MAY_INLINE_DATA flag is set

2023-03-17 08:57:48 +01:00

ioctl.c

ext4: zero i_disksize when initializing the bootloader inode

2023-03-17 08:57:48 +01:00

Kconfig

…

Makefile

…

mballoc.c

ext4: make ext4_mb_initialize_context return void

2022-12-08 21:49:25 -05:00

mballoc.h

ext4: use buckets for cr 1 block scan instead of rbtree

2022-09-21 22:12:03 -04:00

migrate.c

ext4: fix warning in 'ext4_da_release_space'

2022-11-06 01:07:59 -04:00

mmp.c

treewide: use get_random_u32_{above,below}() instead of manual loop

2022-11-18 02:15:22 +01:00

move_extent.c

ext4: convert move_extent_per_page() to use folios

2022-11-30 15:59:02 -08:00

namei.c

ext4: Fix deadlock during directory rename

2023-03-17 08:58:00 +01:00

orphan.c

ext4: remove trailing newline from ext4_msg() message

2022-12-08 21:49:23 -05:00

page-io.c

ext4: fix cgroup writeback accounting with fs-layer encryption

2023-03-17 08:57:47 +01:00

readpage.c

Merge tag 'fsverity-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/fscrypt

2022-12-12 20:06:35 -08:00

resize.c

ext4: fix corruption when online resizing a 1K bigalloc fs

2022-12-08 21:49:24 -05:00

super.c

ext4: fix incorrect options show of original mount_opt and extend mount_opt2

2023-03-11 13:50:33 +01:00

symlink.c

…

sysfs.c

ext4: Fix function prototype mismatch for ext4_feat_ktype

2023-02-25 11:13:29 +01:00

truncate.h

…

verity.c

fs: ext4: initialize fsdata in pagecache_write()

2022-12-08 21:49:25 -05:00

xattr_hurd.c

…

xattr_security.c

…

xattr_trusted.c

…

xattr_user.c

…

xattr.c

ext4: fix WARNING in ext4_update_inline_data

2023-03-17 08:57:48 +01:00

xattr.h

…