Files
twx-linux/fs
Phillip Lougher 3654a0ed0b squashfs: add more sanity checks in xattr id lookup
commit 506220d2ba upstream.

Sysbot has reported a warning where a kmalloc() attempt exceeds the
maximum limit.  This has been identified as corruption of the xattr_ids
count when reading the xattr id lookup table.

This patch adds a number of additional sanity checks to detect this
corruption and others.

1. It checks for a corrupted xattr index read from the inode.  This could
   be because the metadata block is uncompressed, or because the
   "compression" bit has been corrupted (turning a compressed block
   into an uncompressed block).  This would cause an out of bounds read.

2. It checks against corruption of the xattr_ids count.  This can either
   lead to the above kmalloc failure, or a smaller than expected
   table to be read.

3. It checks the contents of the index table for corruption.

[phillip@squashfs.org.uk: fix checkpatch issue]
  Link: https://lkml.kernel.org/r/270245655.754655.1612770082682@webmail.123-reg.co.uk

Link: https://lkml.kernel.org/r/20210204130249.4495-5-phillip@squashfs.org.uk
Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk>
Reported-by: syzbot+2ccea6339d368360800d@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-02-13 13:52:57 +01:00
..
2020-11-05 11:43:34 +01:00
2020-10-29 09:58:03 +01:00
2021-01-30 13:54:11 +01:00
2021-01-09 13:44:54 +01:00
2020-11-18 19:20:30 +01:00
2021-01-30 13:54:11 +01:00
2020-06-17 16:40:24 +02:00
2020-03-05 16:43:36 +01:00
2020-10-01 13:17:19 +02:00
2020-03-25 08:25:58 +01:00
2019-12-17 19:55:30 +01:00