TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
v5.4.6
twx-linux/drivers/pci/hotplug
T
History
Lukas Wunner 9bd9d12339 PCI: pciehp: Avoid returning prematurely from sysfs requests 
commit 157c1062fc upstream.

A sysfs request to enable or disable a PCIe hotplug slot should not
return before it has been carried out.  That is sought to be achieved by
waiting until the controller's "pending_events" have been cleared.

However the IRQ thread pciehp_ist() clears the "pending_events" before
it acts on them.  If pciehp_sysfs_enable_slot() / _disable_slot() happen
to check the "pending_events" after they have been cleared but while
pciehp_ist() is still running, the functions may return prematurely
with an incorrect return value.

Fix by introducing an "ist_running" flag which must be false before a sysfs
request is allowed to return.

Fixes: 32a8cef274 ("PCI: pciehp: Enable/disable exclusively from IRQ thread")
Link: https://lore.kernel.org/linux-pci/1562226638-54134-1-git-send-email-wangxiongfeng2@huawei.com
Link: https://lore.kernel.org/r/4174210466e27eb7e2243dd1d801d5f75baaffd8.1565345211.git.lukas@wunner.de
Reported-and-tested-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-12-21 11:04:27 +01:00
..
acpi_pcihp.c
…
acpiphp_core.c
Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax
2018-10-28 11:35:40 -07:00
acpiphp_glue.c
ACPI / hotplug / PCI: Allocate resources directly under the non-hotplug bridge
2019-12-17 19:56:32 +01:00
acpiphp_ibm.c
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
acpiphp.h
Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax
2018-10-28 11:35:40 -07:00
cpci_hotplug_core.c
PCI: Remove unnecessary returns
2019-08-30 14:00:34 -05:00
cpci_hotplug_pci.c
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
cpci_hotplug.h
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
cpcihp_generic.c
…
cpcihp_zt5550.c
…
cpcihp_zt5550.h
…
cpqphp_core.c
PCI: Remove unnecessary returns
2019-08-30 14:00:34 -05:00
cpqphp_ctrl.c
PCI: Remove unnecessary returns
2019-08-30 14:00:34 -05:00
cpqphp_nvram.c
…
cpqphp_nvram.h
PCI: Remove unnecessary returns
2019-08-30 14:00:34 -05:00
cpqphp_pci.c
…
cpqphp_sysfs.c
…
cpqphp.h
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
ibmphp_core.c
PCI: ibmphp: Turn semaphores into completions or mutexes
2019-01-29 17:15:36 -06:00
ibmphp_ebda.c
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
ibmphp_hpc.c
PCI: ibmphp: Turn semaphores into completions or mutexes
2019-01-29 17:15:36 -06:00
ibmphp_pci.c
…
ibmphp_res.c
PCI: Mark expected switch fall-through
2019-08-08 15:13:34 -05:00
ibmphp.h
PCI: ibmphp: Turn semaphores into completions or mutexes
2019-01-29 17:15:36 -06:00
Kconfig
PCI/hotplug: remove the sgi_hotplug driver
2019-08-16 11:33:56 -07:00
Makefile
PCI/hotplug: remove the sgi_hotplug driver
2019-08-16 11:33:56 -07:00
pci_hotplug_core.c
PCI: hotplug: Drop hotplug_slot_info
2018-09-18 17:52:15 -05:00
pciehp_core.c
PCI: pciehp: Remove pciehp_set_attention_status()
2019-09-05 15:44:08 -05:00
pciehp_ctrl.c
PCI: pciehp: Avoid returning prematurely from sysfs requests
2019-12-21 11:04:27 +01:00
pciehp_hpc.c
PCI: pciehp: Avoid returning prematurely from sysfs requests
2019-12-21 11:04:27 +01:00
pciehp_pci.c
PCI: pciehp: Log messages with pci_dev, not pcie_device
2019-05-09 16:45:20 -05:00
pciehp.h
PCI: pciehp: Avoid returning prematurely from sysfs requests
2019-12-21 11:04:27 +01:00
pnv_php.c
pci-hotplug/pnv_php: Add attention indicator support
2019-09-05 14:22:39 +10:00
rpadlpar_core.c
PCI: Remove unnecessary returns
2019-08-30 14:00:34 -05:00
rpadlpar_sysfs.c
…
rpadlpar.h
…
rpaphp_core.c
Merge tag 'pci-v5.4-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
2019-09-23 19:16:01 -07:00
rpaphp_pci.c
PCI: hotplug: Drop hotplug_slot_info
2018-09-18 17:52:15 -05:00
rpaphp_slot.c
PCI: rpaphp: Get/put device node reference during slot alloc/dealloc
2019-04-10 16:07:12 -05:00
rpaphp.h
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
s390_pci_hpc.c
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
shpchp_core.c
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
shpchp_ctrl.c
PCI: hotplug: Drop hotplug_slot_info
2018-09-18 17:52:15 -05:00
shpchp_hpc.c
…
shpchp_pci.c
…
shpchp_sysfs.c
…
shpchp.h
PCI: hotplug: Embed hotplug_slot
2018-09-18 17:52:15 -05:00
TODO
PCI: hotplug: Document TODOs
2018-09-18 17:52:15 -05:00