TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
v5.4.32
twx-linux/tools/perf/util
T
History
disconnect3d a1081413e8 perf map: Fix off by one in strncpy() size argument 
commit db2c549407 upstream.

This patch fixes an off-by-one error in strncpy size argument in
tools/perf/util/map.c. The issue is that in:

        strncmp(filename, "/system/lib/", 11)

the passed string literal: "/system/lib/" has 12 bytes (without the NULL
byte) and the passed size argument is 11. As a result, the logic won't
match the ending "/" byte and will pass filepaths that are stored in
other directories e.g. "/system/libmalicious/bin" or just
"/system/libmalicious".

This functionality seems to be present only on Android. I assume the
/system/ directory is only writable by the root user, so I don't think
this bug has much (or any) security impact.

Fixes: eca8183699 ("perf tools: Add automatic remapping of Android libraries")
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Changbin Du <changbin.du@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: John Keeping <john@metanate.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Lentine <mlentine@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20200309104855.3775-1-dominik.b.czarnota@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-02 15:11:02 +02:00
..
c++
…
cs-etm-decoder
…
include
…
intel-pt-decoder
…
libunwind
…
scripting-engines
perf scripting engines: Iterate on tep event arrays directly
2019-11-05 08:39:26 -03:00
annotate.c
perf annotate: Fix multiple memory and file descriptor leaks
2019-10-15 12:00:01 -03:00
annotate.h
perf annotate: Don't return -1 for error when doing BPF disassembly
2019-09-30 17:30:06 -03:00
archinsn.h
…
arm-spe-pkt-decoder.c
…
arm-spe-pkt-decoder.h
…
arm-spe.c
…
arm-spe.h
…
auxtrace.c
libperf: Move 'page_size' global variable to libperf
2019-09-25 09:51:48 -03:00
auxtrace.h
perf tools: Rename 'struct perf_mmap' to 'struct mmap'
2019-09-25 09:51:44 -03:00
block-range.c
…
block-range.h
…
bpf_map.c
…
bpf_map.h
…
bpf-event.c
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
bpf-event.h
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
bpf-loader.c
libperf: Add perf_evlist__first()/last() functions
2019-09-25 09:51:48 -03:00
bpf-loader.h
…
bpf-prologue.c
…
bpf-prologue.h
…
branch.c
…
branch.h
…
Build
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
build-id.c
perf copyfile: Move copyfile routines to separate files
2019-09-25 09:51:49 -03:00
build-id.h
…
cache.h
…
cacheline.c
…
cacheline.h
…
call-path.c
…
call-path.h
…
callchain.c
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
callchain.h
…
cap.c
…
cap.h
…
cgroup.c
…
cgroup.h
…
cloexec.c
…
cloexec.h
…
color_config.c
…
color.c
…
color.h
…
comm.c
…
comm.h
…
compress.h
…
config.c
…
config.h
…
copyfile.c
perf tools: Fix mode setting in copyfile_mode_ns()
2019-10-15 12:05:18 -03:00
copyfile.h
perf copyfile: Move copyfile routines to separate files
2019-09-25 09:51:49 -03:00
counts.c
…
counts.h
…
cpu-set-sched.h
…
cpumap.c
…
cpumap.h
…
cputopo.c
…
cputopo.h
…
cs-etm.c
perf cs-etm: Fix definition of macro TO_CS_QUEUE_NR
2019-12-31 16:44:51 +01:00
cs-etm.h
…
data-convert-bt.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
data-convert-bt.h
…
data-convert.h
…
data.c
…
data.h
…
db-export.c
…
db-export.h
…
debug.c
…
debug.h
…
demangle-java.c
…
demangle-java.h
…
demangle-rust.c
…
demangle-rust.h
…
dso.c
…
dso.h
…
dsos.c
…
dsos.h
…
dump-insn.c
…
dump-insn.h
…
dwarf-aux.c
perf probe: Fix to show function entry line as probe-able
2019-12-31 16:45:41 +01:00
dwarf-aux.h
perf probe: Fix to show function entry line as probe-able
2019-12-31 16:45:41 +01:00
dwarf-regs.c
…
env.c
…
env.h
…
event.c
perf tools: Move event synthesizing routines to separate .c file
2019-09-20 10:28:21 -03:00
event.h
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
events_stats.h
…
evlist.c
perf evlist: Fix fix for freed id arrays
2019-10-15 11:51:33 -03:00
evlist.h
perf evlist: Remove unused perf_evlist__fprintf() method
2019-09-25 16:26:40 -03:00
evsel_config.h
perf evsel: Move config terms to a separate header
2019-09-25 16:26:40 -03:00
evsel_fprintf.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
evsel_fprintf.h
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
evsel.c
perf evsel: Fall back to global 'perf_env' in perf_evsel__env()
2019-09-30 17:29:57 -03:00
evsel.h
perf evsel: Move config terms to a separate header
2019-09-25 16:26:40 -03:00
evswitch.c
…
evswitch.h
…
expr.h
…
expr.y
…
find-map.c
…
genelf_debug.c
…
genelf.c
…
genelf.h
perf jvmti: Include JVMTI support for s390
2019-09-25 16:26:41 -03:00
generate-cmdlist.sh
…
get_current_dir_name.c
…
get_current_dir_name.h
…
group.h
…
header.c
perf header: Fix false warning when there are no duplicate cache entries
2020-01-12 12:21:25 +01:00
header.h
perf tools: Move event synthesizing routines to separate .c file
2019-09-20 10:28:21 -03:00
help-unknown-cmd.c
…
help-unknown-cmd.h
…
hist.c
perf tools: Fix time sorting
2019-11-05 08:49:14 -03:00
hist.h
perf hists: Fix variable name's inconsistency in hists__for_each() macro
2020-01-23 08:22:39 +01:00
intel-bts.c
libperf: Move 'ids' from 'struct evsel' to 'struct perf_evsel'
2019-09-25 09:51:47 -03:00
intel-bts.h
…
intel-pt.c
libperf: Move 'ids' from 'struct evsel' to 'struct perf_evsel'
2019-09-25 09:51:47 -03:00
intel-pt.h
…
intlist.c
…
intlist.h
…
jit.h
…
jitdump.c
perf inject jit: Fix JIT_CODE_MOVE filename
2019-09-30 17:29:49 -03:00
jitdump.h
…
kvm-stat.h
perf kvm: Add arch neutral function to choose event for perf kvm record
2019-09-20 10:28:26 -03:00
levenshtein.c
…
levenshtein.h
…
llvm-utils.c
perf llvm: Don't access out-of-scope array
2019-09-30 17:29:35 -03:00
llvm-utils.h
…
lzma.c
…
machine.c
perf map: No need to adjust the long name of modules
2020-01-26 10:01:02 +01:00
machine.h
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
map_groups.h
…
map_symbol.h
…
map.c
perf map: Fix off by one in strncpy() size argument
2020-04-02 15:11:02 +02:00
map.h
…
mem2node.c
…
mem2node.h
…
mem-events.c
…
mem-events.h
…
memswap.c
…
memswap.h
perf memswap: Adopt 'struct u64_swap' from evsel.h
2019-09-20 09:19:22 -03:00
metricgroup.c
perf metricgroup: Fix printing event names of metric group with multiple events
2020-01-12 12:21:25 +01:00
metricgroup.h
…
mmap.c
libperf: Use sys/types.h to get ssize_t, not unistd.h
2019-09-25 09:51:49 -03:00
mmap.h
libperf: Add 'flush' to 'struct perf_mmap'
2019-09-25 09:51:46 -03:00
namespaces.c
perf tools: Move event synthesizing routines to separate .c file
2019-09-20 10:28:21 -03:00
namespaces.h
perf tools: Move event synthesizing routines to separate .c file
2019-09-20 10:28:21 -03:00
ordered-events.c
…
ordered-events.h
…
parse-branch-options.c
…
parse-branch-options.h
…
parse-events.c
perf parse: If pmu configuration fails free terms
2019-12-31 16:45:01 +01:00
parse-events.h
…
parse-events.l
…
parse-events.y
perf parser: Remove needless include directives
2019-09-25 16:26:41 -03:00
parse-regs-options.c
…
parse-regs-options.h
…
path.c
…
path.h
…
perf_event_attr_fprintf.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
perf_regs.c
…
perf_regs.h
perf regs: Make perf_reg_name() return "unknown" instead of NULL
2020-01-04 19:18:27 +01:00
perf-hooks-list.h
…
perf-hooks.c
…
perf-hooks.h
…
PERF-VERSION-GEN
…
pmu.c
…
pmu.h
…
pmu.l
…
pmu.y
…
print_binary.c
…
print_binary.h
…
probe-event.c
perf probe: Fix to clear tev->nargs in clear_probe_trace_event()
2019-09-20 15:30:09 -03:00
probe-event.h
…
probe-file.c
perf probe: Fix to delete multiple probe event
2020-04-01 11:01:59 +02:00
probe-file.h
…
probe-finder.c
perf probe: Do not depend on dwfl_module_addrsym()
2020-04-01 11:02:00 +02:00
probe-finder.h
…
pstack.c
…
pstack.h
…
python-ext-sources
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
python.c
perf evsel: Fall back to global 'perf_env' in perf_evsel__env()
2019-09-30 17:29:57 -03:00
rb_resort.h
…
rblist.c
…
rblist.h
…
record.c
libperf: Add perf_evlist__first()/last() functions
2019-09-25 09:51:48 -03:00
record.h
…
rlimit.c
…
rlimit.h
…
rwsem.c
…
rwsem.h
…
s390-cpumcf-kernel.h
…
s390-cpumsf-kernel.h
…
s390-cpumsf.c
…
s390-cpumsf.h
…
s390-sample-raw.c
…
sample-raw.c
…
sample-raw.h
…
session.c
perf session: Fix decompression of PERF_RECORD_COMPRESSED records
2019-12-31 16:45:40 +01:00
session.h
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
setns.c
…
setup.py
…
smt.c
…
smt.h
…
sort.c
libperf: Add perf_evlist__first()/last() functions
2019-09-25 09:51:48 -03:00
sort.h
…
srccode.c
libperf: Move 'page_size' global variable to libperf
2019-09-25 09:51:48 -03:00
srccode.h
…
srcline.c
…
srcline.h
…
stat-display.c
…
stat-shadow.c
perf stat: Don't report a null stalled cycles per insn metric
2020-02-19 19:53:08 +01:00
stat.c
libperf: Move 'system_wide' from 'struct evsel' to 'struct perf_evsel'
2019-09-25 09:51:46 -03:00
stat.h
perf stat: Reset previous counts on repeat with interval
2019-09-20 10:28:26 -03:00
strbuf.c
…
strbuf.h
…
strfilter.c
…
strfilter.h
…
string2.h
…
string.c
…
strlist.c
…
strlist.h
…
svghelper.c
…
svghelper.h
…
symbol_conf.h
…
symbol_fprintf.c
…
symbol-elf.c
perf copyfile: Move copyfile routines to separate files
2019-09-25 09:51:49 -03:00
symbol-minimal.c
…
symbol.c
…
symbol.h
…
symsrc.h
…
synthetic-events.c
libperf: Move 'page_size' global variable to libperf
2019-09-25 09:51:48 -03:00
synthetic-events.h
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
syscalltbl.c
…
syscalltbl.h
…
target.c
…
target.h
…
term.c
…
term.h
…
thread_map.c
…
thread_map.h
…
thread-stack.c
…
thread-stack.h
…
thread.c
…
thread.h
…
time-utils.c
perf script: Fix --reltime with --time
2020-01-23 08:23:01 +01:00
time-utils.h
perf script: Fix --reltime with --time
2020-01-23 08:23:01 +01:00
tool.h
…
top.c
libperf: Add perf_evlist__first()/last() functions
2019-09-25 09:51:48 -03:00
top.h
…
trace-event-info.c
libperf: Move 'page_size' global variable to libperf
2019-09-25 09:51:48 -03:00
trace-event-parse.c
perf tools: Remove unused trace_find_next_event()
2019-11-05 08:39:27 -03:00
trace-event-read.c
…
trace-event-scripting.c
…
trace-event.c
…
trace-event.h
perf tools: Remove unused trace_find_next_event()
2019-11-05 08:39:27 -03:00
trigger.h
…
tsc.c
…
tsc.h
perf tools: Move event synthesizing routines to separate header
2019-09-20 09:19:22 -03:00
units.c
…
units.h
…
unwind-libdw.c
…
unwind-libdw.h
…
unwind-libunwind-local.c
…
unwind-libunwind.c
…
unwind.h
…
usage.c
…
util.c
perf tools: Fix resource leak of closedir() on the error paths
2019-10-15 11:54:11 -03:00
util.h
perf copyfile: Move copyfile routines to separate files
2019-09-25 09:51:49 -03:00
values.c
…
values.h
…
vdso.c
…
vdso.h
…
xyarray.c
…
zlib.c
…
zstd.c
…