Victor Nogueira 0bf32d6fb1 net_sched: qfq: Fix double list add in class with netem as child qdisc ...

[ Upstream commit f139f37dcd ]

As described in Gerrard's report [1], there are use cases where a netem
child qdisc will make the parent qdisc's enqueue callback reentrant.
In the case of qfq, there won't be a UAF, but the code will add the same
classifier to the list twice, which will cause memory corruption.

This patch checks whether the class was already added to the agg->active
list (cl_is_active) before doing the addition to cater for the reentrant
case.

[1] https://lore.kernel.org/netdev/CAHcdcOm+03OD2j6R0=YHKqmy=VgJ8xEOKuP6c7mSgnp-TEJJbw@mail.gmail.com/

Fixes: 37d9cf1a3c ("sched: Fix detection of empty queues in child qdiscs")
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Link: https://patch.msgid.link/20250425220710.3964791-5-victor@mojatatu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-05-09 09:39:39 +02:00

..

act_api.c

net/sched: act_api: fix possible infinite loop in tcf_idr_check_alloc()

2024-07-05 09:14:30 +02:00

act_bpf.c

…

act_connmark.c

…

act_csum.c

…

act_ct.c

sched: act_ct: take care of padding in struct zones_ht_key

2024-08-19 05:45:31 +02:00

act_ctinfo.c

…

act_gact.c

…

act_gate.c

…

act_ife.c

…

act_ipt.c

net/sched: act_ipt: add sanity checks on table name and hook locations

2023-07-23 13:47:28 +02:00

act_meta_mark.c

…

act_meta_skbprio.c

…

act_meta_skbtcindex.c

…

act_mirred.c

net/sched: act_mirred: don't override retval if we already lost the skb

2025-05-09 09:39:37 +02:00

act_mpls.c

…

act_nat.c

…

act_pedit.c

net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX

2023-07-23 13:47:29 +02:00

act_police.c

…

act_sample.c

…

act_simple.c

…

act_skbedit.c

…

act_skbmod.c

net/sched: act_skbmod: prevent kernel-infoleak

2024-04-10 16:19:38 +02:00

act_tunnel_key.c

net: fix geneve_opt length integer overflow

2025-04-10 14:32:05 +02:00

act_vlan.c

…

cls_api.c

net/sched: cls_api: Fix lockup on flushing explicitly created chain

2023-06-21 15:59:18 +02:00

cls_basic.c

…

cls_bpf.c

net: sched: cls_bpf: Undo tcf_bind_filter in case of an error

2023-07-27 08:47:00 +02:00

cls_cgroup.c

…

cls_flow.c

net_sched: cls_flow: validate TCA_FLOW_RSHIFT attribute

2025-01-23 17:15:49 +01:00

cls_flower.c

net: fix geneve_opt length integer overflow

2025-04-10 14:32:05 +02:00

cls_fw.c

net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free

2023-08-11 15:13:52 +02:00

cls_matchall.c

…

cls_route.c

net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free

2023-08-11 15:13:52 +02:00

cls_u32.c

net: sched: cls_u32: Fix allocation size in u32_init()

2023-11-08 17:26:45 +01:00

em_canid.c

…

em_cmp.c

…

em_ipset.c

…

em_ipt.c

…

em_meta.c

…

em_nbyte.c

…

em_text.c

net: sched: em_text: fix possible memory leak in em_text_destroy()

2024-01-15 18:51:12 +01:00

em_u32.c

…

ematch.c

…

Kconfig

net/sched: Retire dsmark qdisc

2024-03-01 13:21:42 +01:00

Makefile

net/sched: Retire dsmark qdisc

2024-03-01 13:21:42 +01:00

sch_api.c

net_sched: Prevent creation of classes with TC_H_ROOT

2025-04-10 14:31:49 +02:00

sch_blackhole.c

…

sch_cake.c

sched: sch_cake: add bounds checks to host bulk flow fairness counts

2025-03-13 12:51:12 +01:00

sch_cbs.c

net/sched: cbs: Fix integer overflow in cbs_set_port_rate()

2024-12-14 19:51:36 +01:00

sch_choke.c

net: sched: fix ordering of qlen adjustment

2025-01-09 13:28:29 +01:00

sch_codel.c

…

sch_drr.c

net_sched: drr: Fix double list add in class with netem as child qdisc

2025-05-09 09:39:38 +02:00

sch_etf.c

…

sch_ets.c

net_sched: ets: Fix double list add in class with netem as child qdisc

2025-05-09 09:39:38 +02:00

sch_fifo.c

pfifo_tail_enqueue: Drop new packet when sch->limit == 0

2025-03-13 12:51:00 +01:00

sch_fq_codel.c

…

sch_fq_pie.c

net/sched: fq_pie: avoid stalls in fq_pie_timer()

2023-09-19 12:22:58 +02:00

sch_fq.c

…

sch_frag.c

…

sch_generic.c

…

sch_gred.c

…

sch_hfsc.c

net_sched: hfsc: Fix a UAF vulnerability in class with netem as child qdisc

2025-05-09 09:39:38 +02:00

sch_hhf.c

…

sch_htb.c

…

sch_ingress.c

…

sch_mq.c

…

sch_mqprio.c

net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64

2023-08-03 10:22:36 +02:00

sch_multiq.c

net: sched: sch_multiq: fix possible OOB write in multiq_tune()

2024-07-05 09:14:06 +02:00

sch_netem.c

netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()

2025-03-13 12:50:23 +01:00

sch_pie.c

…

sch_plug.c

net: sched: sch_qfq: Fix UAF in qfq_dequeue()

2023-09-19 12:22:59 +02:00

sch_prio.c

…

sch_qfq.c

net_sched: qfq: Fix double list add in class with netem as child qdisc

2025-05-09 09:39:39 +02:00

sch_red.c

…

sch_sfb.c

…

sch_sfq.c

…

sch_skbprio.c

net_sched: skbprio: Remove overly strict queue assertions

2025-04-10 14:32:04 +02:00

sch_taprio.c

net: sched: fix use-after-free in taprio_change()

2024-11-01 01:52:37 +01:00

sch_tbf.c

net/sched: tbf: correct backlog statistic for GSO packets

2024-12-14 19:51:27 +01:00

sch_teql.c

…