Dennis Yang 1773131ec4 dm thin: fix a memory leak when passing discard bio down ...

commit 948f581a53 upstream.

dm-thin does not free the discard_parent bio after all chained sub
bios finished. The following kmemleak report could be observed after
pool with discard_passdown option processes discard bios in
linux v4.11-rc7. To fix this, we drop the discard_parent bio reference
when its endio (passdown_endio) called.

unreferenced object 0xffff8803d6b29700 (size 256):
  comm "kworker/u8:0", pid 30349, jiffies 4379504020 (age 143002.776s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    01 00 00 00 00 00 00 f0 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81a5efd9>] kmemleak_alloc+0x49/0xa0
    [<ffffffff8114ec34>] kmem_cache_alloc+0xb4/0x100
    [<ffffffff8110eec0>] mempool_alloc_slab+0x10/0x20
    [<ffffffff8110efa5>] mempool_alloc+0x55/0x150
    [<ffffffff81374939>] bio_alloc_bioset+0xb9/0x260
    [<ffffffffa018fd20>] process_prepared_discard_passdown_pt1+0x40/0x1c0 [dm_thin_pool]
    [<ffffffffa018b409>] break_up_discard_bio+0x1a9/0x200 [dm_thin_pool]
    [<ffffffffa018b484>] process_discard_cell_passdown+0x24/0x40 [dm_thin_pool]
    [<ffffffffa018b24d>] process_discard_bio+0xdd/0xf0 [dm_thin_pool]
    [<ffffffffa018ecf6>] do_worker+0xa76/0xd50 [dm_thin_pool]
    [<ffffffff81086239>] process_one_work+0x139/0x370
    [<ffffffff810867b1>] worker_thread+0x61/0x450
    [<ffffffff8108b316>] kthread+0xd6/0xf0
    [<ffffffff81a6cd1f>] ret_from_fork+0x3f/0x70
    [<ffffffffffffffff>] 0xffffffffffffffff

Signed-off-by: Dennis Yang <dennisyang@qnap.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2017-05-20 14:28:37 +02:00

..

bcache

bcache: Make gc wakeup sane, remove set_task_state()

2017-02-23 17:44:36 +01:00

persistent-data

dm space map metadata: fix 'struct sm_metadata' leak on failed create

2017-01-06 10:40:16 +01:00

bitmap.c

md/bitmap: fix wrong cleanup

2016-09-21 09:09:44 -07:00

bitmap.h

md-cluster: sync bitmap when node received RESYNCING msg

2016-05-04 12:39:35 -07:00

dm-bio-prison.c

…

dm-bio-prison.h

…

dm-bio-record.h

…

dm-bufio.c

Merge tag 'dm-4.9-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2016-10-09 17:16:18 -07:00

dm-bufio.h

…

dm-builtin.c

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

dm-cache-block-types.h

…

dm-cache-metadata.c

dm cache metadata: switch to using the new cursor api for loading metadata

2016-09-22 11:15:05 -04:00

dm-cache-metadata.h

…

dm-cache-policy-cleaner.c

dm cache: speed up writing of the hint array

2016-09-22 11:15:02 -04:00

dm-cache-policy-internal.h

dm cache: speed up writing of the hint array

2016-09-22 11:15:02 -04:00

dm-cache-policy-smq.c

dm cache policy smq: distribute entries to random levels when switching to smq

2016-09-22 11:15:03 -04:00

dm-cache-policy.c

…

dm-cache-policy.h

dm cache: speed up writing of the hint array

2016-09-22 11:15:02 -04:00

dm-cache-target.c

dm cache: fix corruption seen when using cache > 2TB

2017-03-12 06:41:44 +01:00

dm-core.h

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

dm-crypt.c

dm crypt: mark key as invalid until properly loaded

2017-01-06 10:40:15 +01:00

dm-delay.c

…

dm-era-target.c

dm era: save spacemap metadata root after the pre-commit

2017-05-20 14:28:37 +02:00

dm-exception-store.c

…

dm-exception-store.h

…

dm-flakey.c

dm flakey: return -EINVAL on interval bounds error in flakey_ctr()

2017-01-06 10:40:15 +01:00

dm-io.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

dm-ioctl.c

dm ioctl: prevent stack leak in dm ioctl call

2017-05-08 07:47:55 +02:00

dm-kcopyd.c

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

dm-linear.c

Merge tag 'libnvdimm-for-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm

2016-07-28 17:38:16 -07:00

dm-log-userspace-base.c

…

dm-log-userspace-transfer.c

…

dm-log-userspace-transfer.h

…

dm-log-writes.c

Merge branch 'for-4.9/block' of git://git.kernel.dk/linux-block

2016-10-07 14:42:05 -07:00

dm-log.c

dm log: fix unitialized bio operation flags

2016-08-24 21:55:05 -04:00

dm-mpath.c

dm mpath: always return reservation conflict without failing over

2016-09-29 10:57:07 -04:00

dm-mpath.h

…

dm-path-selector.c

…

dm-path-selector.h

…

dm-queue-length.c

…

dm-raid1.c

dm mirror: use all available legs on multiple failures

2016-10-14 11:55:17 -04:00

dm-raid.c

dm raid: fix NULL pointer dereference for raid1 without bitmap

2017-04-12 12:41:13 +02:00

dm-region-hash.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

dm-round-robin.c

dm round robin: revert "use percpu 'repeat_count' and 'current_path'"

2017-03-12 06:41:44 +01:00

dm-rq.c

dm rq: check blk_mq_register_dev() return value in dm_mq_init_request_queue()

2017-05-20 14:28:37 +02:00

dm-rq.h

dm rq: introduce dm_mq_kick_requeue_list()

2016-09-15 11:16:05 -04:00

dm-service-time.c

…

dm-snap-persistent.c

dm: use bio op accessors

2016-06-07 13:41:38 -06:00

dm-snap-transient.c

…

dm-snap.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

dm-stats.c

dm stats: fix a leaked s->histogram_boundaries array

2017-03-12 06:41:44 +01:00

dm-stats.h

…

dm-stripe.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

dm-switch.c

…

dm-sysfs.c

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

dm-table.c

dm table: an 'all_blk_mq' table must be loaded for a blk-mq DM device

2017-01-06 10:40:15 +01:00

dm-target.c

Merge tag 'libnvdimm-for-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm

2016-07-28 17:38:16 -07:00

dm-thin-metadata.c

dm thin: fix a race condition between discarding and provisioning a block

2016-07-20 12:43:35 -04:00

dm-thin-metadata.h

dm thin: fix a race condition between discarding and provisioning a block

2016-07-20 12:43:35 -04:00

dm-thin.c

dm thin: fix a memory leak when passing discard bio down

2017-05-20 14:28:37 +02:00

dm-uevent.c

…

dm-uevent.h

…

dm-verity-fec.c

dm verity fec: fix bufio leaks

2017-04-12 12:41:12 +02:00

dm-verity-fec.h

dm verity fec: limit error correction recursion

2017-04-12 12:41:12 +02:00

dm-verity-target.c

…

dm-verity.h

…

dm-zero.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

dm.c

blk: Ensure users for current->bio_list can see the full list.

2017-04-08 09:30:36 +02:00

dm.h

dm: add infrastructure for DAX support

2016-07-20 23:49:49 -04:00

faulty.c

…

Kconfig

…

linear.c

md linear: fix a race between linear_add() and linear_congested()

2017-03-12 06:41:52 +01:00

linear.h

md linear: fix a race between linear_add() and linear_congested()

2017-03-12 06:41:52 +01:00

Makefile

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

md-cluster.c

md-cluster: make resync lock also could be interruptted

2016-09-21 09:09:44 -07:00

md-cluster.h

md-cluster: gather resync infos and enable recv_thread after bitmap is ready

2016-05-09 09:24:03 -07:00

md.c

md: fix refcount problem on mddev when stopping array.

2017-01-12 11:39:35 +01:00

md.h

md: changes for MD_STILL_CLOSED flag

2016-09-21 09:09:44 -07:00

multipath.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

multipath.h

…

raid0.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

raid0.h

…

raid1.c

raid1: handle read error also in readonly mode

2016-10-28 22:04:04 -07:00

raid1.h

…

raid5-cache.c

raid5-cache: correct condition for empty metadata write

2016-10-28 22:04:03 -07:00

raid5.c

md/raid5: limit request size according to implementation limits

2017-01-09 08:32:22 +01:00

raid5.h

md/raid5: Convert to hotplug state machine

2016-09-06 18:30:23 +02:00

raid10.c

blk: Ensure users for current->bio_list can see the full list.

2017-04-08 09:30:36 +02:00

raid10.h

raid10: improve random reads performance

2016-07-19 15:20:28 -07:00