TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
v4.4.9
twx-linux/drivers/scsi
T
History
Arnd Bergmann 5b6e810f35 megaraid_sas: add missing curly braces in ioctl handler 
commit 3deb9438d3 upstream.

gcc-6 found a dubious indentation in the megasas_mgmt_fw_ioctl
function:

drivers/scsi/megaraid/megaraid_sas_base.c: In function 'megasas_mgmt_fw_ioctl':
drivers/scsi/megaraid/megaraid_sas_base.c:6658:4: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
    kbuff_arr[i] = NULL;
    ^~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_base.c:6653:3: note: ...this 'if' clause, but it is not
   if (kbuff_arr[i])
   ^~

The code is actually correct, as there is no downside in clearing a NULL
pointer again.

This clarifies the code and avoids the warning by adding extra curly
braces.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 90dc9d98f0 ("megaraid_sas : MFI MPT linked list corruption fix")
Reviewed-by: Hannes Reinecke <hare@suse.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-05-04 14:48:54 -07:00
..
aacraid
aacraid: Set correct msix count for EEH recovery
2016-04-12 09:08:38 -07:00
aic7xxx
aic7xxx: Fix queue depth handling
2016-04-12 09:08:39 -07:00
aic94xx
Merge tag '4.4-scsi-mkp' into misc
2015-11-12 07:06:18 -05:00
arcmsr
Merge tag 'libnvdimm-for-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
2015-09-08 14:35:59 -07:00
arm
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
be2iscsi
be2iscsi: set the boot_kset pointer to NULL in case of failure
2016-04-12 09:08:39 -07:00
bfa
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
bnx2fc
bnx2fc: Update version number to 2.9.6.
2015-11-09 17:32:34 -08:00
bnx2i
bnx2i: Fix call trace while device reset
2015-06-02 17:15:24 -07:00
csiostor
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
cxgbi
drivers/scsi/cxgbi: fix build with EXTRA_CFLAGS
2015-11-09 15:11:24 -08:00
cxlflash
cxlflash: Fix to avoid bypassing context cleanup
2015-10-30 17:25:34 +09:00
device_handler
scsi_dh: force modular build if SCSI is a module
2016-05-04 14:48:51 -07:00
dpt
…
esas2r
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
fcoe
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
fnic
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
ibmvscsi
Merge tag '4.4-scsi-mkp' into misc
2015-11-12 07:06:18 -05:00
isci
Merge tag '4.4-scsi-mkp' into misc
2015-11-12 07:06:18 -05:00
libfc
libfc: Use the correct function name in kernel-doc comment.
2015-11-09 17:15:52 -08:00
libsas
Merge branch 'for-4.0-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2015-03-24 17:08:29 -07:00
lpfc
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
megaraid
megaraid_sas: add missing curly braces in ioctl handler
2016-05-04 14:48:54 -07:00
mpt3sas
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
mvsas
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
osd
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2015-04-14 09:50:27 -07:00
pcmcia
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
pm8001
Merge tag '4.4-scsi-mkp' into misc
2015-11-12 07:06:18 -05:00
qla2xxx
qla2xxx: Fix stale pointer access.
2016-03-03 15:07:27 -08:00
qla4xxx
Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2015-11-13 20:35:54 -08:00
snic
Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2015-11-13 20:35:54 -08:00
sym53c8xx_2
…
ufs
Merge tag '4.4-scsi-mkp' into misc
2015-11-12 07:06:18 -05:00
.gitignore
…
3w-9xxx.c
3w-9xxx: don't unmap bounce buffered commands
2015-10-07 10:24:48 -07:00
3w-9xxx.h
3w-9xxx: fix command completion race
2015-04-27 10:10:19 -07:00
3w-sas.c
3w-sas: fix command completion race
2015-04-27 10:04:39 -07:00
3w-sas.h
3w-sas: fix command completion race
2015-04-27 10:04:39 -07:00
3w-xxxx.c
3w-xxxx: fix command completion race
2015-04-27 10:05:55 -07:00
3w-xxxx.h
3w-xxxx: fix command completion race
2015-04-27 10:05:55 -07:00
53c700_d.h_shipped
…
53c700.c
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
53c700.h
…
53c700.scr
…
a100u2w.c
scsi: a100u2w: trivial typo in printk
2015-08-07 15:03:42 +02:00
a100u2w.h
…
a2091.c
…
a2091.h
…
a3000.c
…
a3000.h
…
a4000t.c
…
advansys.c
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
aha152x.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
aha152x.h
…
aha1542.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
aha1542.h
aha1542: fix include guard and remove useless changelog
2015-04-09 18:08:31 -07:00
aha1740.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
aha1740.h
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
am53c974.c
am53c974: Fix crash during modprobe
2015-04-17 10:13:56 -07:00
atari_NCR5380.c
ncr5380: Harmonize jiffies conversion with msecs_to_jiffies
2015-03-09 10:45:26 -04:00
atari_scsi.c
ncr5380: Drop owner assignment from platform_drivers
2015-03-09 07:18:14 -04:00
atp870u.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
atp870u.h
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
BusLogic.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
BusLogic.h
…
bvme6000_scsi.c
…
ch.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2015-04-14 09:50:27 -07:00
constants.c
scsi: Conditionally compile in constants.c
2015-01-09 15:44:31 +01:00
dc395x.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
dc395x.h
…
dmx3191d.c
…
dpt_i2o.c
x86/vm86: Clean up vm86.h includes
2015-07-31 13:31:10 +02:00
dpti.h
…
dtc.c
…
dtc.h
…
eata_generic.h
…
eata_pio.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
eata_pio.h
…
eata.c
…
esp_scsi.c
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
esp_scsi.h
…
fdomain.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
fdomain.h
…
FlashPoint.c
FlashPoint: fix build warning
2015-11-09 16:32:14 -08:00
g_NCR5380_mmio.c
…
g_NCR5380.c
ncr5380: Harmonize jiffies conversion with msecs_to_jiffies
2015-03-09 10:45:26 -04:00
g_NCR5380.h
…
gdth_ioctl.h
…
gdth_proc.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
gdth_proc.h
…
gdth.c
…
gdth.h
…
gvp11.c
…
gvp11.h
…
hosts.c
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
hpsa_cmd.h
hpsa: add in sas transport class
2015-11-09 12:39:28 -05:00
hpsa.c
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
hpsa.h
hpsa: add in sas transport class
2015-11-09 12:39:28 -05:00
hptiop.c
hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer
2015-08-12 13:14:57 -07:00
hptiop.h
hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer
2015-08-12 13:14:57 -07:00
imm.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
imm.h
…
in2000.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
in2000.h
…
initio.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
initio.h
…
ipr.c
ipr: Fix regression when loading firmware
2016-04-12 09:08:58 -07:00
ipr.h
ipr: Driver version 2.6.3.
2015-11-09 19:32:41 -05:00
ips.c
ips: remove pointless #warning
2015-06-02 17:24:54 -07:00
ips.h
…
iscsi_boot_sysfs.c
…
iscsi_tcp.c
…
iscsi_tcp.h
…
jazz_esp.c
…
Kconfig
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
lasi700.c
…
libiscsi_tcp.c
…
libiscsi.c
libiscsi: Fix iscsi_check_transport_timeouts possible infinite loop
2015-09-17 07:25:02 -07:00
mac53c94.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
mac53c94.h
…
mac_esp.c
…
mac_scsi.c
ncr5380: Drop owner assignment from platform_drivers
2015-03-09 07:18:14 -04:00
Makefile
mpt3sas: Single driver module which supports both SAS 2.0 & SAS 3.0 HBAs
2015-11-11 19:50:11 -05:00
megaraid.c
megaraid : use dev_printk when possible
2015-08-26 07:23:04 -07:00
megaraid.h
…
mesh.c
powerpc: Move Power Macintosh drivers to generic byteswappers
2015-03-23 14:29:40 +11:00
mesh.h
…
mvme16x_scsi.c
…
mvme147.c
…
mvme147.h
…
mvumi.c
mvumi: 64bit value for seconds_since1970
2015-11-11 20:45:23 -05:00
mvumi.h
…
ncr53c8xx.c
…
ncr53c8xx.h
…
NCR53c406a.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
NCR5380.c
ncr5380: Harmonize jiffies conversion with msecs_to_jiffies
2015-03-09 10:45:26 -04:00
NCR5380.h
…
NCR_D700.c
…
NCR_D700.h
…
NCR_Q720.c
…
NCR_Q720.h
…
nsp32_debug.c
…
nsp32_io.h
…
nsp32.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
nsp32.h
…
osst_detect.h
…
osst_options.h
…
osst.c
…
osst.h
…
pas16.c
…
pas16.h
…
pmcraid.c
Merge tag '4.4-scsi-mkp' into misc
2015-11-12 07:06:18 -05:00
pmcraid.h
…
ppa.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
ppa.h
…
ps3rom.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qla1280.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qla1280.h
…
qlogicfas408.c
…
qlogicfas408.h
…
qlogicfas.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qlogicpti.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qlogicpti.h
…
raid_class.c
…
script_asm.pl
…
scsi_common.c
scsi_common: do not clobber fixed sense information
2016-04-12 09:09:05 -07:00
scsi_debug.c
scsi_debug: fix prevent_allow+verify regressions
2015-11-25 21:38:53 -05:00
scsi_devinfo.c
SCSI: Add Marvell Console to VPD blacklist
2016-02-25 12:01:16 -08:00
scsi_dh.c
scsi_dh: don't try to load a device handler during async probing
2015-10-27 15:03:31 +09:00
scsi_error.c
mm, page_alloc: rename __GFP_WAIT to __GFP_RECLAIM
2015-11-06 17:50:42 -08:00
scsi_ioctl.c
…
scsi_lib_dma.c
…
scsi_lib.c
mm, page_alloc: rename __GFP_WAIT to __GFP_RECLAIM
2015-11-06 17:50:42 -08:00
scsi_logging.c
scsi_logging: return void for dev_printk() functions
2015-02-04 08:00:24 -08:00
scsi_logging.h
…
scsi_module.c
…
scsi_netlink.c
…
scsi_pm.c
Revert "SCSI: Fix NULL pointer dereference in runtime PM"
2015-12-10 12:24:44 -05:00
scsi_priv.h
scsi_dh: fix use-after-free when removing scsi device
2015-10-27 11:22:37 +09:00
scsi_proc.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
scsi_sas_internal.h
…
scsi_scan.c
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
scsi_sysctl.c
…
scsi_sysfs.c
scsi: fix soft lockup in scsi_remove_target() on module removal
2016-02-25 12:01:17 -08:00
scsi_trace.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
scsi_transport_api.h
…
scsi_transport_fc.c
scsi_transport_fc: Add support for 25Gbit speed
2015-04-10 07:40:32 -07:00
scsi_transport_iscsi.c
Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2015-09-02 12:22:54 -07:00
scsi_transport_sas.c
scsi_transport_sas: Remove check for SAS expander when querying bay/enclosure IDs.
2015-09-06 11:13:41 -07:00
scsi_transport_spi.c
[SCSI] Fix printk typos in drivers/scsi
2015-08-07 14:28:45 +02:00
scsi_transport_srp.c
IB/srp: Avoid using uninitialized variable
2015-07-14 13:20:09 -04:00
scsi_typedefs.h
…
scsi.c
scsi: use host wide tags by default
2015-11-09 17:11:57 -08:00
scsi.h
…
scsicam.c
…
sd_dif.c
block: Consolidate static integrity profile properties
2015-10-21 14:42:38 -06:00
sd.c
sd: Fix excessive capacity printing on devices with blocks bigger than 512 bytes
2016-04-20 15:42:12 +09:00
sd.h
sd: Fix excessive capacity printing on devices with blocks bigger than 512 bytes
2016-04-20 15:42:12 +09:00
ses.c
ses: fix additional element traversal bug
2015-12-11 11:05:57 -08:00
sg.c
sg: fix dxferp in from_to case
2016-04-12 09:08:38 -07:00
sgiwd93.c
…
sim710.c
…
sni_53c710.c
…
sr_ioctl.c
sr: reduce debug noise in sr_do_ioctl
2015-01-20 19:43:24 +01:00
sr_vendor.c
…
sr.c
SCSI: fix crashes in sd and sr runtime PM
2016-02-25 12:01:16 -08:00
sr.h
…
st_options.h
…
st.c
Merge branch 'mkp-fixes' into fixes
2015-12-03 09:32:33 -08:00
st.h
st: implement tape statistics
2015-06-02 08:03:25 -07:00
stex.c
stex: Remove use of struct timeval
2015-11-09 17:42:19 -08:00
storvsc_drv.c
scsi: storvsc: fix SRB_STATUS_ABORTED handling
2016-04-12 09:08:39 -07:00
sun3_scsi_vme.c
…
sun3_scsi.c
ncr5380: Drop owner assignment from platform_drivers
2015-03-09 07:18:14 -04:00
sun3_scsi.h
…
sun3x_esp.c
arch, drivers: don't include <asm/io.h> directly, use <linux/io.h> instead
2015-08-10 23:07:05 -04:00
sun_esp.c
…
sym53c416.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
sym53c416.h
…
t128.c
…
t128.h
…
u14-34f.c
…
ultrastor.c
…
ultrastor.h
…
virtio_scsi.c
Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
2015-07-23 13:07:04 -07:00
vmw_pvscsi.c
…
vmw_pvscsi.h
…
wd33c93.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
wd33c93.h
…
wd719x.c
[SCSI] Fix printk typos in drivers/scsi
2015-08-07 14:28:45 +02:00
wd719x.h
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
wd7000.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
xen-scsifront.c
xen: Use correctly the Xen memory terminologies
2015-09-08 18:03:49 +01:00
zalon.c
…
zorro7xx.c
…