Eric Dumazet b7f47c794b ping: implement proper locking ...

commit 43a6684519 upstream.

We got a report of yet another bug in ping

http://www.openwall.com/lists/oss-security/2017/03/24/6

->disconnect() is not called with socket lock held.

Fix this by acquiring ping rwlock earlier.

Thanks to Daniel, Alexander and Andrey for letting us know this problem.

Fixes: c319b4d76b ("net: ipv4: add IPPROTO_ICMP socket kind")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Daniel Jiang <danieljiang0415@gmail.com>
Reported-by: Solar Designer <solar@openwall.com>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2017-04-30 05:49:29 +02:00

..

netfilter

netfilter: x_tables: introduce and use xt_copy_counters_from_user

2016-06-24 10:18:24 -07:00

af_inet.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

ah4.c

…

arp.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-10-20 06:08:27 -07:00

cipso_ipv4.c

netlabel: out of bound access in cipso_v4_validate()

2017-02-18 16:39:26 +01:00

datagram.c

…

devinet.c

ipv4: Don't do expensive useless work during inetdev destroy.

2016-04-20 15:42:03 +09:00

esp4.c

esp4: Fix integrity verification when ESN are used

2016-12-10 19:07:26 +01:00

fib_frontend.c

ipv4: provide stronger user input validation in nl_fib_input()

2017-03-30 09:35:14 +02:00

fib_lookup.h

…

fib_rules.c

…

fib_semantics.c

net: lwtunnel: Handle lwtunnel_fill_encap failure

2017-02-04 09:45:08 +01:00

fib_trie.c

fib_trie: Correct /proc/net/route off by one error

2016-11-21 10:06:40 +01:00

fou.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

gre_demux.c

…

gre_offload.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

icmp.c

Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"

2015-10-14 06:01:07 -07:00

igmp.c

igmp: Make igmp group member RFC 3376 compliant

2017-01-15 13:41:35 +01:00

inet_connection_sock.c

tcp/dccp: fix another race at listener dismantle

2016-03-03 15:07:07 -08:00

inet_diag.c

tcp/dccp: install syn_recv requests into ehash table

2015-10-03 04:32:41 -07:00

inet_fragment.c

net: fix percpu memory leaks

2015-11-02 22:47:14 -05:00

inet_hashtables.c

tcp/dccp: fix hashdance race for passive sessions

2015-10-23 05:42:21 -07:00

inet_lro.c

…

inet_timewait_sock.c

tcp/dccp: fix timewait races in timer handling

2015-09-21 16:32:29 -07:00

inetpeer.c

…

ip_forward.c

net: Pass net into dst_output and remove dst_output_okfn

2015-10-08 04:26:54 -07:00

ip_fragment.c

inet: frag: Always orphan skbs inside ip_defrag()

2016-03-03 15:07:04 -08:00

ip_gre.c

vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-06-24 10:18:18 -07:00

ip_input.c

ipv4: Pass struct net into ip_defrag and ip_check_defrag

2015-10-12 19:44:16 -07:00

ip_options.c

…

ip_output.c

ipv4: Set skb->protocol properly for local output

2016-12-10 19:07:26 +01:00

ip_sockglue.c

ip: fix IP_CHECKSUM handling

2017-02-26 11:07:50 +01:00

ip_tunnel_core.c

tunnels: Remove encapsulation offloads on decap.

2016-10-31 04:13:59 -06:00

ip_tunnel.c

vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-06-24 10:18:18 -07:00

ip_vti.c

vti: flush x-netns xfrm cache when vti interface is removed

2016-09-30 10:18:36 +02:00

ipcomp.c

…

ipconfig.c

ipconfig: send Client-identifier in DHCP requests

2015-10-18 19:23:52 -07:00

ipip.c

ipip: ioctl: Remove superfluous IP-TTL handling.

2015-12-18 16:07:59 -05:00

ipmr.c

ipmr, ip6mr: fix scheduling while atomic and a deadlock with ipmr_get_route

2016-11-15 07:46:37 +01:00

Kconfig

…

Makefile

tcp: track the packet timings in RACK

2015-10-21 07:00:48 -07:00

netfilter.c

ipv4: Pass struct net into ip_route_me_harder

2015-09-29 20:21:32 +02:00

ping.c

ping: implement proper locking

2017-04-30 05:49:29 +02:00

proc.c

…

protocol.c

…

raw.c

ipv4: fix memory leaks in ip_cmsg_send() callers

2016-03-03 15:07:06 -08:00

route.c

ipv4: mask tos for input route

2017-03-22 12:04:14 +01:00

syncookies.c

tcp/dccp: fix hashdance race for passive sessions

2015-10-23 05:42:21 -07:00

sysctl_net_ipv4.c

ipv4: use the right lock for ping_group_range

2016-11-15 07:46:38 +01:00

tcp_bic.c

…

tcp_cdg.c

…

tcp_cong.c

tcp: remove tcp_ecn_make_synack() socket argument

2015-09-25 13:00:38 -07:00

tcp_cubic.c

tcp_cubic: do not set epoch_start in the future

2015-09-17 22:35:07 -07:00

tcp_dctcp.c

dctcp: avoid bogus doubling of cwnd after loss

2016-11-21 10:06:39 +01:00

tcp_diag.c

tcp: ensure proper barriers in lockless contexts

2015-11-15 18:36:38 -05:00

tcp_fastopen.c

tcp: initialize max window for a new fastopen socket

2017-02-04 09:45:09 +01:00

tcp_highspeed.c

…

tcp_htcp.c

…

tcp_hybla.c

…

tcp_illinois.c

…

tcp_input.c

tcp: initialize icsk_ack.lrcvtime at session start time

2017-03-30 09:35:14 +02:00

tcp_ipv4.c

dccp/tcp: fix routing redirect race

2017-03-22 12:04:17 +01:00

tcp_lp.c

…

tcp_memcontrol.c

…

tcp_metrics.c

tcp: convert cached rtt from usec to jiffies when feeding initial rto

2016-04-20 15:41:56 +09:00

tcp_minisocks.c

tcp: initialize icsk_ack.lrcvtime at session start time

2017-03-30 09:35:14 +02:00

tcp_offload.c

…

tcp_output.c

tcp: fix 0 divide in __tcp_select_window()

2017-02-18 16:39:26 +01:00

tcp_probe.c

…

tcp_recovery.c

tcp: use RACK to detect losses

2015-10-21 07:00:53 -07:00

tcp_scalable.c

…

tcp_timer.c

tcp: fix various issues for sockets morphing to listen state

2017-03-22 12:04:15 +01:00

tcp_vegas.c

…

tcp_vegas.h

…

tcp_veno.c

…

tcp_westwood.c

…

tcp_yeah.c

tcp: cwnd does not increase in TCP YeAH

2016-09-30 10:18:34 +02:00

tcp.c

tcp: avoid infinite loop in tcp_splice_read()

2017-02-18 16:39:27 +01:00

tunnel4.c

…

udp_diag.c

…

udp_impl.h

…

udp_offload.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

udp_tunnel.c

tunnel: Clear IPCB(skb)->opt before dst_link_failure called

2016-04-20 15:41:56 +09:00

udp.c

udp: fix IP_CHECKSUM handling

2016-11-15 07:46:39 +01:00

udplite.c

…

xfrm4_input.c

netfilter: Pass net into okfn

2015-09-17 17:18:37 -07:00

xfrm4_mode_beet.c

…

xfrm4_mode_transport.c

…

xfrm4_mode_tunnel.c

…

xfrm4_output.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-10-24 06:54:12 -07:00

xfrm4_policy.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec

2015-12-22 16:26:31 -05:00

xfrm4_protocol.c

…

xfrm4_state.c

…

xfrm4_tunnel.c

…