WANG Cong afb4feb8bf ping: fix a null pointer dereference ...

[ Upstream commit 73d2c6678e ]

Andrey reported a kernel crash:

  general protection fault: 0000 [#1] SMP KASAN
  Dumping ftrace buffer:
     (ftrace buffer empty)
  Modules linked in:
  CPU: 2 PID: 3880 Comm: syz-executor1 Not tainted 4.10.0-rc6+ #124
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
  task: ffff880060048040 task.stack: ffff880069be8000
  RIP: 0010:ping_v4_push_pending_frames net/ipv4/ping.c:647 [inline]
  RIP: 0010:ping_v4_sendmsg+0x1acd/0x23f0 net/ipv4/ping.c:837
  RSP: 0018:ffff880069bef8b8 EFLAGS: 00010206
  RAX: dffffc0000000000 RBX: ffff880069befb90 RCX: 0000000000000000
  RDX: 0000000000000018 RSI: ffff880069befa30 RDI: 00000000000000c2
  RBP: ffff880069befbb8 R08: 0000000000000008 R09: 0000000000000000
  R10: 0000000000000002 R11: 0000000000000000 R12: ffff880069befab0
  R13: ffff88006c624a80 R14: ffff880069befa70 R15: 0000000000000000
  FS:  00007f6f7c716700(0000) GS:ffff88006de00000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00000000004a6f28 CR3: 000000003a134000 CR4: 00000000000006e0
  Call Trace:
   inet_sendmsg+0x164/0x5b0 net/ipv4/af_inet.c:744
   sock_sendmsg_nosec net/socket.c:635 [inline]
   sock_sendmsg+0xca/0x110 net/socket.c:645
   SYSC_sendto+0x660/0x810 net/socket.c:1687
   SyS_sendto+0x40/0x50 net/socket.c:1655
   entry_SYSCALL_64_fastpath+0x1f/0xc2

This is because we miss a check for NULL pointer for skb_peek() when
the queue is empty. Other places already have the same check.

Fixes: c319b4d76b ("net: ipv4: add IPPROTO_ICMP socket kind")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2017-02-18 16:39:27 +01:00

..

netfilter

netfilter: x_tables: introduce and use xt_copy_counters_from_user

2016-06-24 10:18:24 -07:00

af_inet.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

ah4.c

ah4: Fix error return in ah_input().

2015-08-25 13:38:50 -07:00

arp.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-10-20 06:08:27 -07:00

cipso_ipv4.c

netlabel: out of bound access in cipso_v4_validate()

2017-02-18 16:39:26 +01:00

datagram.c

net: Set sk_txhash from a random number

2015-07-29 22:44:04 -07:00

devinet.c

ipv4: Don't do expensive useless work during inetdev destroy.

2016-04-20 15:42:03 +09:00

esp4.c

esp4: Fix integrity verification when ESN are used

2016-12-10 19:07:26 +01:00

fib_frontend.c

ipv4: Do not allow MAIN to be alias for new LOCAL w/ custom rules

2017-01-15 13:41:35 +01:00

fib_lookup.h

ipv4: consider TOS in fib_select_default

2015-07-24 22:46:11 -07:00

fib_rules.c

net: ipv6: use common fib_default_rule_pref

2015-09-09 14:19:50 -07:00

fib_semantics.c

net: lwtunnel: Handle lwtunnel_fill_encap failure

2017-02-04 09:45:08 +01:00

fib_trie.c

fib_trie: Correct /proc/net/route off by one error

2016-11-21 10:06:40 +01:00

fou.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

gre_demux.c

gre: Remove support for sharing GRE protocol hook.

2015-08-10 14:03:54 -07:00

gre_offload.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

icmp.c

Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"

2015-10-14 06:01:07 -07:00

igmp.c

igmp: Make igmp group member RFC 3376 compliant

2017-01-15 13:41:35 +01:00

inet_connection_sock.c

tcp/dccp: fix another race at listener dismantle

2016-03-03 15:07:07 -08:00

inet_diag.c

tcp/dccp: install syn_recv requests into ehash table

2015-10-03 04:32:41 -07:00

inet_fragment.c

net: fix percpu memory leaks

2015-11-02 22:47:14 -05:00

inet_hashtables.c

tcp/dccp: fix hashdance race for passive sessions

2015-10-23 05:42:21 -07:00

inet_lro.c

…

inet_timewait_sock.c

tcp/dccp: fix timewait races in timer handling

2015-09-21 16:32:29 -07:00

inetpeer.c

net: Add helper function to compare inetpeer addresses

2015-08-28 13:32:36 -07:00

ip_forward.c

net: Pass net into dst_output and remove dst_output_okfn

2015-10-08 04:26:54 -07:00

ip_fragment.c

inet: frag: Always orphan skbs inside ip_defrag()

2016-03-03 15:07:04 -08:00

ip_gre.c

vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-06-24 10:18:18 -07:00

ip_input.c

ipv4: Pass struct net into ip_defrag and ip_check_defrag

2015-10-12 19:44:16 -07:00

ip_options.c

…

ip_output.c

ipv4: Set skb->protocol properly for local output

2016-12-10 19:07:26 +01:00

ip_sockglue.c

ipv4: keep skb->dst around in presence of IP options

2017-02-18 16:39:26 +01:00

ip_tunnel_core.c

tunnels: Remove encapsulation offloads on decap.

2016-10-31 04:13:59 -06:00

ip_tunnel.c

vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices

2016-06-24 10:18:18 -07:00

ip_vti.c

vti: flush x-netns xfrm cache when vti interface is removed

2016-09-30 10:18:36 +02:00

ipcomp.c

…

ipconfig.c

ipconfig: send Client-identifier in DHCP requests

2015-10-18 19:23:52 -07:00

ipip.c

ipip: ioctl: Remove superfluous IP-TTL handling.

2015-12-18 16:07:59 -05:00

ipmr.c

ipmr, ip6mr: fix scheduling while atomic and a deadlock with ipmr_get_route

2016-11-15 07:46:37 +01:00

Kconfig

geneve: Consolidate Geneve functionality in single module.

2015-08-27 15:42:48 -07:00

Makefile

tcp: track the packet timings in RACK

2015-10-21 07:00:48 -07:00

netfilter.c

ipv4: Pass struct net into ip_route_me_harder

2015-09-29 20:21:32 +02:00

ping.c

ping: fix a null pointer dereference

2017-02-18 16:39:27 +01:00

proc.c

net: track success and failure of TCP PMTU probing

2015-07-21 22:36:33 -07:00

protocol.c

…

raw.c

ipv4: fix memory leaks in ip_cmsg_send() callers

2016-03-03 15:07:06 -08:00

route.c

net: ipv4: fix table id in getroute response

2017-02-04 09:45:08 +01:00

syncookies.c

tcp/dccp: fix hashdance race for passive sessions

2015-10-23 05:42:21 -07:00

sysctl_net_ipv4.c

ipv4: use the right lock for ping_group_range

2016-11-15 07:46:38 +01:00

tcp_bic.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_cdg.c

tcp: do not slow start when cwnd equals ssthresh

2015-07-09 14:22:52 -07:00

tcp_cong.c

tcp: remove tcp_ecn_make_synack() socket argument

2015-09-25 13:00:38 -07:00

tcp_cubic.c

tcp_cubic: do not set epoch_start in the future

2015-09-17 22:35:07 -07:00

tcp_dctcp.c

dctcp: avoid bogus doubling of cwnd after loss

2016-11-21 10:06:39 +01:00

tcp_diag.c

tcp: ensure proper barriers in lockless contexts

2015-11-15 18:36:38 -05:00

tcp_fastopen.c

tcp: initialize max window for a new fastopen socket

2017-02-04 09:45:09 +01:00

tcp_highspeed.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_htcp.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_hybla.c

tcp: do not slow start when cwnd equals ssthresh

2015-07-09 14:22:52 -07:00

tcp_illinois.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_input.c

tcp: fix a compile error in DBGUNDO()

2016-11-15 07:46:36 +01:00

tcp_ipv4.c

tcp: take care of truncations done by sk_filter()

2016-11-21 10:06:40 +01:00

tcp_lp.c

…

tcp_memcontrol.c

…

tcp_metrics.c

tcp: convert cached rtt from usec to jiffies when feeding initial rto

2016-04-20 15:41:56 +09:00

tcp_minisocks.c

tcp: fix tcpi_segs_in after connection establishment

2016-04-20 15:42:00 +09:00

tcp_offload.c

…

tcp_output.c

tcp: fix 0 divide in __tcp_select_window()

2017-02-18 16:39:26 +01:00

tcp_probe.c

…

tcp_recovery.c

tcp: use RACK to detect losses

2015-10-21 07:00:53 -07:00

tcp_scalable.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_timer.c

tcp: fix Fast Open snmp over-counting bug

2015-11-20 10:51:12 -05:00

tcp_vegas.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_vegas.h

…

tcp_veno.c

tcp: add tcp_in_slow_start helper

2015-07-09 14:22:52 -07:00

tcp_westwood.c

…

tcp_yeah.c

tcp: cwnd does not increase in TCP YeAH

2016-09-30 10:18:34 +02:00

tcp.c

tcp: avoid infinite loop in tcp_splice_read()

2017-02-18 16:39:27 +01:00

tunnel4.c

…

udp_diag.c

…

udp_impl.h

…

udp_offload.c

net: add recursion limit to GRO

2016-11-15 07:46:38 +01:00

udp_tunnel.c

tunnel: Clear IPCB(skb)->opt before dst_link_failure called

2016-04-20 15:41:56 +09:00

udp.c

udp: fix IP_CHECKSUM handling

2016-11-15 07:46:39 +01:00

udplite.c

…

xfrm4_input.c

netfilter: Pass net into okfn

2015-09-17 17:18:37 -07:00

xfrm4_mode_beet.c

…

xfrm4_mode_transport.c

…

xfrm4_mode_tunnel.c

…

xfrm4_output.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-10-24 06:54:12 -07:00

xfrm4_policy.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec

2015-12-22 16:26:31 -05:00

xfrm4_protocol.c

…

xfrm4_state.c

…

xfrm4_tunnel.c

…