Thiago Rafael Becker 58330ec2fe kernel: make groups_sort calling a responsibility group_info allocators ...

commit bdcf0a423e upstream.

In testing, we found that nfsd threads may call set_groups in parallel
for the same entry cached in auth.unix.gid, racing in the call of
groups_sort, corrupting the groups for that entry and leading to
permission denials for the client.

This patch:
 - Make groups_sort globally visible.
 - Move the call to groups_sort to the modifiers of group_info
 - Remove the call to groups_sort from set_groups

Link: http://lkml.kernel.org/r/20171211151420.18655-1-thiago.becker@gmail.com
Signed-off-by: Thiago Rafael Becker <thiago.becker@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Acked-by: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-01-10 09:27:10 +01:00

..

vdso32

s390/vdso: emit a GNU hash

2015-08-07 09:57:39 +02:00

vdso64

s390/vdso: emit a GNU hash

2015-08-07 09:57:39 +02:00

.gitignore

…

asm-offsets.c

s390/kvm: remove dependency on struct save_area definition

2016-03-03 15:07:11 -08:00

audit.c

…

audit.h

…

base.S

s390/kdump: fix nosmt kernel parameter

2015-06-25 09:39:26 +02:00

cache.c

s390/cachinfo: add missing facility check to init_cache_level()

2015-07-28 08:54:42 +02:00

compat_audit.c

…

compat_linux.c

kernel: make groups_sort calling a responsibility group_info allocators

2018-01-10 09:27:10 +01:00

compat_linux.h

…

compat_ptrace.h

…

compat_signal.c

s390/compat: correct restore of high gprs on signal return

2016-03-03 15:07:12 -08:00

compat_wrapper.c

s390: wire up mlock2 system call

2015-11-16 12:51:07 +01:00

cpcmd.c

s390/diag: add a statistic for diagnose calls

2015-10-14 14:32:06 +02:00

crash_dump.c

s390/kdump: Add final note

2017-05-25 14:30:09 +02:00

debug.c

s390: time: Provide read_boot_clock64() and read_persistent_clock64()

2015-05-22 10:36:29 -07:00

diag.c

s390/diag: add a s390 prefix to the diagnose trace point

2015-11-09 09:10:47 +01:00

dis.c

s390/disassembler: increase show_code buffer size

2017-11-30 08:37:18 +00:00

dumpstack.c

…

early.c

s390: fix transactional execution control register handling

2017-11-30 08:37:18 +00:00

ebcdic.c

…

entry.h

s390/udelay: make udelay have busy loop semantics

2015-10-14 14:32:13 +02:00

entry.S

s390/kvm: do not rely on the ILC on kvm host protection fauls

2017-06-17 06:39:38 +02:00

ftrace.c

s390/maccess: remove potentially broken probe_kernel_write()

2015-03-25 11:49:43 +01:00

head64.S

s390/cpumf: Fix lpp detection

2016-04-12 09:08:31 -07:00

head_kdump.S

…

head.S

s390: remove SALIPL loader

2015-11-16 12:51:11 +01:00

idle.c

…

ipl.c

Revert "s390/kdump: Clear subchannel ID to signal non-CCW/SCSI IPL"

2016-08-16 09:30:49 +02:00

irq.c

s390: remove runtime instrumentation interrupts

2015-11-03 14:40:51 +01:00

jump_label.c

Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2015-09-03 15:46:07 -07:00

kprobes.c

s390/maccess: remove potentially broken probe_kernel_write()

2015-03-25 11:49:43 +01:00

lgr.c

…

machine_kexec.c

…

Makefile

s390/diag: add tracepoint for diagnose calls

2015-10-14 14:32:06 +02:00

mcount.S

…

module.c

…

nmi.c

s390/nmi: reduce size of percpu variable

2015-10-27 09:33:57 +01:00

os_info.c

…

perf_cpum_cf_events.c

…

perf_cpum_cf.c

Merge branch 'linus' into perf/core, to pick up fixes before applying new changes

2015-09-28 08:06:57 +02:00

perf_cpum_sf.c

s390/cpumf: rework program parameter setting to detect guest samples

2015-10-14 14:32:12 +02:00

perf_event.c

…

pgm_check.S

…

process.c

s390/runtime instrumentation: simplify task exit handling

2017-12-09 18:42:38 +01:00

processor.c

s390/diag: add a statistic for diagnose calls

2015-10-14 14:32:06 +02:00

ptrace.c

s390/ptrace: Preserve previous registers for short regset write

2017-02-01 08:30:52 +01:00

reipl.S

…

relocate_kernel.S

…

runtime_instr.c

s390/runtime instrumentation: simplify task exit handling

2017-12-09 18:42:38 +01:00

s390_ksyms.c

s390/fpu: split fpu-internal.h into fpu internals, api, and type headers

2015-10-16 09:41:12 +02:00

sclp.c

s390/sclp: _sclp_wait_int(): retain full PSW mask

2015-11-12 13:08:00 +01:00

setup.c

s390: use correct input data address for setup_randomness

2017-03-15 09:57:12 +08:00

signal.c

s390/fpu: always enable the vector facility if it is available

2015-10-14 14:32:08 +02:00

smp.c

s390/cpumf: rework program parameter setting to detect guest samples

2015-10-14 14:32:12 +02:00

stacktrace.c

…

suspend.c

PCI: Include <linux/pci.h>, not <asm/pci.h>

2015-06-08 07:55:03 -05:00

swsusp.S

s390/hibernate: fix save and restore of vector registers

2015-09-17 13:43:41 +02:00

sys_s390.c

…

syscalls.S

s390: fix compat system call table

2017-12-16 10:33:49 +01:00

sysinfo.c

…

time.c

s390/etr,stp: fix possible deadlock on machine check

2015-10-14 14:32:18 +02:00

topology.c

s390/topology: reduce per_cpu() invocations

2015-10-27 09:34:39 +01:00

trace.c

s390/diag: add a s390 prefix to the diagnose trace point

2015-11-09 09:10:47 +01:00

traps.c

s390/fpu: split fpu-internal.h into fpu internals, api, and type headers

2015-10-16 09:41:12 +02:00

uprobes.c

s390/uprobes: fix address space annotation

2015-03-25 11:49:47 +01:00

vdso.c

s390/vdso: use correct memory barrier

2015-10-14 14:32:01 +02:00

vmlinux.lds.S

…

vtime.c

s390/vtime: correct scaled cputime of partially idle CPUs

2015-09-30 16:22:38 +02:00