Herbert Xu 90060df5c2 crypto: api - Fix race condition in crypto_spawn_alg ...

commit 73669cc556 upstream.

The function crypto_spawn_alg is racy because it drops the lock
before shooting the dying algorithm.  The algorithm could disappear
altogether before we shoot it.

This patch fixes it by moving the shooting into the locked section.

Fixes: 6bfd48096f ("[CRYPTO] api: Added spawns")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-02-14 16:32:14 -05:00

..

asymmetric_keys

crypto: asymmetric_keys - select CRYPTO_HASH where needed

2019-07-31 07:28:31 +02:00

async_tx

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

.gitignore

…

842.c

…

ablk_helper.c

…

ablkcipher.c

crypto: skcipher - Fix -Wstringop-truncation warnings

2018-10-03 17:00:45 -07:00

acompress.c

…

aead.c

…

aes_generic.c

…

aes_ti.c

crypto: aes_ti - disable interrupts while accessing S-box

2019-02-12 19:45:57 +01:00

af_alg.c

crypto: af_alg - Use bh_lock_sock in sk_destruct

2020-02-05 14:18:10 +00:00

ahash.c

crypto: hash - set CRYPTO_TFM_NEED_KEY if ->setkey() fails

2019-03-23 14:35:18 +01:00

akcipher.c

…

algapi.c

crypto: api - Fix race condition in crypto_spawn_alg

2020-02-14 16:32:14 -05:00

algboss.c

…

algif_aead.c

crypto: af_alg - Fix race around ctx->rcvused by making it atomic_t

2018-03-03 10:24:29 +01:00

algif_hash.c

crypto: hash - prevent using keyed hashes without setting key

2018-02-16 20:23:00 +01:00

algif_rng.c

…

algif_skcipher.c

crypto: af_alg - Fix race around ctx->rcvused by making it atomic_t

2018-03-03 10:24:29 +01:00

ansi_cprng.c

…

anubis.c

…

api.c

crypto: api - Fix race condition in crypto_spawn_alg

2020-02-14 16:32:14 -05:00

arc4.c

…

authenc.c

crypto: authenc - fix parsing key with misaligned rta_len

2019-01-23 08:09:48 +01:00

authencesn.c

crypto: authencesn - Avoid twice completion call in decrypt path

2019-01-23 08:09:47 +01:00

blkcipher.c

crypto: skcipher - Fix -Wstringop-truncation warnings

2018-10-03 17:00:45 -07:00

blowfish_common.c

…

blowfish_generic.c

…

camellia_generic.c

…

cast5_generic.c

…

cast6_generic.c

…

cast_common.c

…

cbc.c

…

ccm.c

crypto: ccm - fix incompatibility between "ccm" and "ccm_base"

2019-05-21 18:50:20 +02:00

chacha20_generic.c

crypto: chacha20 - fix handling of chunked input

2017-08-22 14:45:47 +08:00

chacha20poly1305.c

crypto: chacha20poly1305 - fix atomic sleep when using async algorithm

2019-07-31 07:28:35 +02:00

cipher.c

…

cmac.c

…

compress.c

…

crc32_generic.c

crypto: hash - annotate algorithms taking optional key

2018-02-16 20:23:00 +01:00

crc32c_generic.c

crypto: hash - annotate algorithms taking optional key

2018-02-16 20:23:00 +01:00

crct10dif_common.c

…

crct10dif_generic.c

crypto: crct10dif-generic - fix use via crypto_shash_digest()

2019-05-21 18:50:15 +02:00

cryptd.c

crypto: cryptd - Fix skcipher instance memory leak

2019-07-10 09:54:38 +02:00

crypto_engine.c

crypto: engine - replace pr_xxx by dev_xxx

2017-06-19 14:19:54 +08:00

crypto_null.c

…

crypto_user.c

crypto: user - fix memory leak in crypto_report

2019-12-17 20:38:55 +01:00

crypto_wq.c

…

ctr.c

crypto: algapi - make crypto_xor() take separate dst and src arguments

2017-08-04 09:27:15 +08:00

cts.c

…

deflate.c

…

des_generic.c

…

dh_helper.c

crypto: dh - Don't permit 'key' or 'g' size longer than 'p'

2017-11-21 09:49:21 +01:00

dh.c

crypto: dh - Fix double free of ctx->p

2017-11-21 09:49:20 +01:00

drbg.c

crypto: drbg - set freed buffers to NULL

2018-05-01 12:58:23 -07:00

ecb.c

…

ecc_curve_defs.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

ecc.c

crypto: ecdh - fix big endian bug in ECC library

2019-12-17 20:38:55 +01:00

ecc.h

…

ecdh_helper.c

…

ecdh.c

crypto: ecdh - fix concurrency on shared secret and pubkey

2017-08-03 13:47:22 +08:00

echainiv.c

…

fcrypt.c

…

fips.c

…

gcm.c

crypto: gcm - fix incompatibility between "gcm" and "gcm_base"

2019-05-21 18:50:15 +02:00

gf128mul.c

…

ghash-generic.c

crypto: ghash - fix unaligned memory access in ghash_setkey()

2019-07-31 07:28:35 +02:00

hash_info.c

…

hmac.c

crypto: hmac - require that the underlying hash algorithm is unkeyed

2017-12-20 10:10:17 +01:00

internal.h

crypto: api - Fix race condition in crypto_spawn_alg

2020-02-14 16:32:14 -05:00

jitterentropy-kcapi.c

…

jitterentropy.c

…

Kconfig

crypto: aes_ti - disable interrupts while accessing S-box

2019-02-12 19:45:57 +01:00

keywrap.c

…

khazad.c

…

kpp.c

…

lrw.c

crypto: lrw - Fix out-of bounds access on counter overflow

2018-11-13 11:15:07 -08:00

lz4.c

…

lz4hc.c

…

lzo.c

…

Makefile

crypto: aes-generic - fix aes-generic regression on powerpc

2018-09-19 22:43:37 +02:00

mcryptd.c

crypto: hash - annotate algorithms taking optional key

2018-02-16 20:23:00 +01:00

md4.c

…

md5.c

…

memneq.c

…

michael_mic.c

…

pcbc.c

crypto: pcbc - remove bogus memcpy()s with src == dest

2019-03-23 14:35:21 +01:00

pcrypt.c

crypto: pcrypt - Do not clear MAY_SLEEP flag in original request

2020-02-14 16:32:14 -05:00

poly1305_generic.c

crypto: poly1305 - remove ->setkey() method

2018-02-16 20:23:00 +01:00

proc.c

…

ripemd.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

rmd128.c

…

rmd160.c

…

rmd256.c

…

rmd320.c

…

rng.c

crypto: rng - ensure that the RNG is ready before using

2017-07-28 17:56:00 +08:00

rsa_helper.c

crypto: rsa - fix buffer overread when stripping leading zeroes

2017-12-20 10:10:17 +01:00

rsa-pkcs1pad.c

crypto: fix a memory leak in rsa-kcs1pad's encryption mode

2019-11-20 18:00:47 +01:00

rsa.c

…

rsaprivkey.asn1

…

rsapubkey.asn1

…

salsa20_generic.c

crypto: salsa20 - don't access already-freed walk.iv

2019-05-21 18:50:19 +02:00

scatterwalk.c

…

scompress.c

crypto: scompress - defer allocation of scratch buffer to first use

2017-08-03 13:52:44 +08:00

seed.c

…

seqiv.c

…

serpent_generic.c

crypto: serpent - mark __serpent_setkey_sbox noinline

2019-07-31 07:28:30 +02:00

sha1_generic.c

…

sha3_generic.c

crypto: sha3-generic - fixes for alignment and big endian operation

2018-02-03 17:38:51 +01:00

sha256_generic.c

…

sha512_generic.c

…

shash.c

crypto: hash - set CRYPTO_TFM_NEED_KEY if ->setkey() fails

2019-03-23 14:35:18 +01:00

simd.c

crypto: simd - correctly take reqsize of wrapped skcipher into account

2018-12-01 09:42:53 +01:00

skcipher.c

crypto: skcipher - Unmap pages after an external error

2019-10-11 18:18:32 +02:00

tcrypt.c

crypto: tcrypt - fix ghash-generic speed test

2018-11-13 11:15:07 -08:00

tcrypt.h

…

tea.c

…

testmgr.c

crypto: testmgr - skip crc32c context test for ahash algorithms

2019-03-23 14:35:18 +01:00

testmgr.h

crypto: x86/poly1305 - fix overflow during partial reduction

2019-04-27 09:35:37 +02:00

tgr192.c

crypto: tgr192 - fix unaligned memory access

2020-01-27 14:46:13 +01:00

twofish_common.c

…

twofish_generic.c

…

vmac.c

crypto: vmac - separate tfm and request context

2018-08-17 21:01:10 +02:00

wp512.c

…

xcbc.c

…

xor.c

kmemcheck: stop using GFP_NOTRACK and SLAB_NOTRACK

2018-02-22 15:42:23 +01:00

xts.c

crypto: xts - Fix an error handling path in 'create()'

2017-10-07 12:04:31 +08:00