David Disseldorp 1addb798e9 null_blk: fix dev->badblocks leak ... null_alloc_dev() allocates memory for dev->badblocks, but cleanup currently only occurs in the configfs release codepath, missing a number of other places. This bug was found running the blktests block/010 test, alongside kmemleak: rapido1:/blktests# ./check block/010 ... rapido1:/blktests# echo scan > /sys/kernel/debug/kmemleak [ 306.966708] kmemleak: 32 new suspected memory leaks (see /sys/kernel/debug/kmemleak) rapido1:/blktests# cat /sys/kernel/debug/kmemleak unreferenced object 0xffff88001f86d000 (size 4096): comm "modprobe", pid 231, jiffies 4294892415 (age 318.252s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff814b0379>] kmemleak_alloc+0x49/0xa0 [<ffffffff810f180f>] kmem_cache_alloc+0x9f/0xe0 [<ffffffff8124e45f>] badblocks_init+0x2f/0x60 [<ffffffffa0019fae>] 0xffffffffa0019fae [<ffffffffa0021273>] nullb_device_badblocks_store+0x63/0x130 [null_blk] [<ffffffff810004cd>] do_one_initcall+0x3d/0x170 [<ffffffff8109fe0d>] do_init_module+0x56/0x1e9 [<ffffffff8109ebd7>] load_module+0x1c47/0x26a0 [<ffffffff8109f819>] SyS_finit_module+0xa9/0xd0 [<ffffffff814b4f60>] entry_SYSCALL_64_fastpath+0x13/0x94 Fixes: 2f54a613c942 ("nullb: badbblocks support") Reviewed-by: Shaohua Li <shli@fb.com> Signed-off-by: David Disseldorp <ddiss@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2017-11-22 08:43:11 -07:00
..
accessibility
acpi	ACPI fix for v4.15-rc1	2017-11-17 14:51:24 -08:00
amba
android
ata
atm
auxdisplay
base	Two power management fixes for v4.15-rc1	2017-11-17 14:49:25 -08:00
bcma
block	null_blk: fix dev->badblocks leak	2017-11-22 08:43:11 -07:00
bluetooth
bus
cdrom
char	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
clk	We have two changes to the core framework this time around. The first being a	2017-11-17 20:04:24 -08:00
clocksource
connector
cpufreq
cpuidle
crypto
dax	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
dca
devfreq
dio
dma
dma-buf	Tracing updates for 4.15:	2017-11-17 14:58:01 -08:00
edac
eisa
extcon
firewire
firmware	remoteproc updates for v4.15	2017-11-17 20:14:10 -08:00
fmc
fpga
fsi
gpio
gpu	amdgpu DC display code for Vega.	2017-11-17 14:34:42 -08:00
hid
hsi
hv
hwmon
hwspinlock	hwspinlock update for v4.15	2017-11-17 20:16:20 -08:00
hwtracing
i2c	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
ide	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2017-11-17 10:56:56 -08:00
idle
iio
infiniband
input
iommu
ipack
irqchip
isdn
leds
lightnvm
macintosh
mailbox
mcb
md	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2017-11-17 10:56:56 -08:00
media
memory
memstick
message
mfd
misc	lkdtm: include WARN format string	2017-11-17 16:10:01 -08:00
mmc
mtd	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
mux
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-17 20:18:37 -08:00
nfc
ntb
nubus
nvdimm	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
nvme
nvmem
of
opp
oprofile
parisc
parport
pci
pcmcia	drivers/pcmcia/sa1111_badge4.c: avoid unused function warning	2017-11-17 16:10:04 -08:00
perf
phy
pinctrl
platform	clean up x86 platform driver default values	2017-11-18 12:09:51 -08:00
pnp
power
powercap
pps
ps3
ptp
pwm
rapidio	Merge branch 'akpm' (patches from Andrew)	2017-11-17 16:56:17 -08:00
ras
regulator
remoteproc	remoteproc updates for v4.15	2017-11-17 20:14:10 -08:00
reset
rpmsg	rpmsg updates for v4.15	2017-11-17 20:12:08 -08:00
rtc
s390	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2017-11-17 14:23:52 -08:00
sbus	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc	2017-11-17 20:21:44 -08:00
scsi	Merge branch 'work.get_user_pages_fast' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:38:51 -08:00
sfi
sh
sn
soc
spi
spmi
ssb
staging	Merge branch 'work.get_user_pages_fast' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:38:51 -08:00
target
tc
tee
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2017-11-17 14:31:27 -08:00
thunderbolt
tty	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
uio
usb
uwb
vfio
vhost	Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:08:18 -08:00
video	Merge branch 'work.get_user_pages_fast' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:38:51 -08:00
virt
virtio
vlynq
vme
w1
watchdog	drivers/watchdog: make use of devm_register_reboot_notifier()	2017-11-17 16:10:04 -08:00
xen	Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:08:18 -08:00
zorro
Kconfig
Makefile