TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
eadb60bcc2005247d97dcb3becee57aba4024ff4
twx-linux/arch/s390/include/asm
T
History
Vasily Gorbik aa2f15f54d s390/ftrace: fix ftrace_update_ftrace_func implementation 
commit f8c2602733 upstream.

s390 enforces DYNAMIC_FTRACE if FUNCTION_TRACER is selected.
At the same time implementation of ftrace_caller is not compliant with
HAVE_DYNAMIC_FTRACE since it doesn't provide implementation of
ftrace_update_ftrace_func() and calls ftrace_trace_function() directly.

The subtle difference is that during ftrace code patching ftrace
replaces function tracer via ftrace_update_ftrace_func() and activates
it back afterwards. Unexpected direct calls to ftrace_trace_function()
during ftrace code patching leads to nullptr-dereferences when tracing
is activated for one of functions which are used during code patching.
Those function currently are:
copy_from_kernel_nofault()
copy_from_kernel_nofault_allowed()
preempt_count_sub() [with debug_defconfig]
preempt_count_add() [with debug_defconfig]

Corresponding KASAN report:
 BUG: KASAN: nullptr-dereference in function_trace_call+0x316/0x3b0
 Read of size 4 at addr 0000000000001e08 by task migration/0/15

 CPU: 0 PID: 15 Comm: migration/0 Tainted: G B 5.13.0-41423-g08316af3644d
 Hardware name: IBM 3906 M04 704 (LPAR)
 Stopper: multi_cpu_stop+0x0/0x3e0 <- stop_machine_cpuslocked+0x1e4/0x218
 Call Trace:
  [<0000000001f77caa>] show_stack+0x16a/0x1d0
  [<0000000001f8de42>] dump_stack+0x15a/0x1b0
  [<0000000001f81d56>] print_address_description.constprop.0+0x66/0x2e0
  [<000000000082b0ca>] kasan_report+0x152/0x1c0
  [<00000000004cfd8e>] function_trace_call+0x316/0x3b0
  [<0000000001fb7082>] ftrace_caller+0x7a/0x7e
  [<00000000006bb3e6>] copy_from_kernel_nofault_allowed+0x6/0x10
  [<00000000006bb42e>] copy_from_kernel_nofault+0x3e/0xd0
  [<000000000014605c>] ftrace_make_call+0xb4/0x1f8
  [<000000000047a1b4>] ftrace_replace_code+0x134/0x1d8
  [<000000000047a6e0>] ftrace_modify_all_code+0x120/0x1d0
  [<000000000047a7ec>] __ftrace_modify_code+0x5c/0x78
  [<000000000042395c>] multi_cpu_stop+0x224/0x3e0
  [<0000000000423212>] cpu_stopper_thread+0x33a/0x5a0
  [<0000000000243ff2>] smpboot_thread_fn+0x302/0x708
  [<00000000002329ea>] kthread+0x342/0x408
  [<00000000001066b2>] __ret_from_fork+0x92/0xf0
  [<0000000001fb57fa>] ret_from_fork+0xa/0x30

 The buggy address belongs to the page:
 page:(____ptrval____) refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1
 flags: 0x1ffff00000001000(reserved|node=0|zone=0|lastcpupid=0x1ffff)
 raw: 1ffff00000001000 0000040000000048 0000040000000048 0000000000000000
 raw: 0000000000000000 0000000000000000 ffffffff00000001 0000000000000000
 page dumped because: kasan: bad access detected

 Memory state around the buggy address:
  0000000000001d00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
  0000000000001d80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
 >0000000000001e00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
                       ^
  0000000000001e80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
  0000000000001f00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
 ==================================================================

To fix that introduce ftrace_func callback to be called from
ftrace_caller and update it in ftrace_update_ftrace_func().

Fixes: 4cc9bed034 ("[S390] cleanup ftrace backend functions")
Cc: stable@vger.kernel.org
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-28 11:13:49 +02:00
..
fpu
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
airq.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
alternative-asm.h
s390: add assembler macros for CPU alternatives
2018-03-28 08:38:27 +02:00
alternative.h
s390: add a few more SPDX identifiers
2017-12-05 07:51:09 +01:00
ap.h
s390/ap: rework assembler functions to use unions for in/out register variables
2019-06-25 11:35:53 +08:00
appldata.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
archrandom.h
s390/archrandom: Rework arch random implementation.
2018-05-30 11:18:04 +02:00
asm-prototypes.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
atomic_ops.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
atomic.h
atomics/treewide: Make conditional inc/dec ops optional
2018-06-21 14:25:24 +02:00
barrier.h
s390: add optimized array_index_mask_nospec
2018-02-05 07:51:41 +01:00
bitops.h
s390/bitops: add test_and_clear_bit_inv()
2018-01-26 10:47:38 +01:00
bug.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bugs.h
s390: add a few more SPDX identifiers
2017-12-05 07:51:09 +01:00
cache.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ccwdev.h
s390/cio: add helper to query utility strings per given ccw device
2018-05-23 08:06:56 +02:00
ccwgroup.h
s390/cio: add test for ccwgroup device
2018-05-23 08:06:58 +02:00
checksum.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
chpid.h
s390/cio: rename struct channel_path_desc
2018-03-26 16:13:11 +02:00
cio.h
s390: assume diag308 set always works
2018-04-10 07:38:59 +02:00
clp.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cmb.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cmpxchg.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compat.h
y2038: s390: Remove unneeded ipc uapi header files
2018-04-20 16:19:58 +02:00
cpacf.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
cpcmd.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cpu_mf.h
s390/cpum_sf: save TOD clock base in SDBs for time conversion
2018-07-31 11:02:27 +02:00
cpu.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cpufeature.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cputime.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
crw.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
css_chars.h
s390/cio: sanitize css_general_characteristics definition
2018-06-12 15:14:05 +02:00
ctl_reg.h
KVM: s390: introduce defines for control registers
2018-05-17 09:02:27 +02:00
current.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debug.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
delay.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
diag.h
s390/diag: add diag26c support for VNIC info
2018-01-02 13:52:23 -05:00
dis.h
s390/tools: generate header files in arch/s390/include/generated/
2018-01-23 07:36:53 +01:00
dma.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dwarf.h
s390/vdso: revise CFI annotations of vDSO functions
2017-12-13 10:51:36 +01:00
eadm.h
s390/eadm: fix CONFIG_BLOCK include dependency
2018-02-02 10:47:14 +01:00
ebcdic.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
elf.h
s390: limit brk randomization to 32MB
2019-05-04 09:20:11 +02:00
exec.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
extable.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
extmem.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
facility.h
s390: fix stfle zero padding
2019-07-21 09:03:14 +02:00
fcx.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ftrace.h
s390/ftrace: fix ftrace_update_ftrace_func implementation
2021-07-28 11:13:49 +02:00
futex.h
s390: remove all code using the access register mode
2017-11-14 11:01:47 +01:00
gmap.h
s390/mm: Add huge page dirty sync support
2018-07-30 11:20:18 +01:00
hardirq.h
softirq/s390: Move default mutators of overwritten softirq mask to s390
2018-05-14 11:25:28 +02:00
hugetlb.h
s390/mm: Clear skeys for newly mapped huge guest pmds
2018-07-30 11:20:18 +01:00
hw_irq.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
idals.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
idle.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
io.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ipl.h
s390/ipl: correct kdump reipl block checksum calculation
2018-04-10 07:39:00 +02:00
irq.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
irqflags.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
isc.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
itcw.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
jump_label.h
s390/jump_label: Use "jdd" constraint on gcc9
2019-06-25 11:35:52 +08:00
Kbuild
Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
2018-02-01 16:56:07 -08:00
kdebug.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
kexec.h
s390/kexec_file: Add ELF loader
2018-04-16 09:10:23 +02:00
kprobes.h
s390/kprobes: Remove jprobe implementation
2018-06-21 12:33:10 +02:00
kvm_host.h
KVM: s390: reduce number of IO pins to 1
2020-07-16 08:17:20 +02:00
kvm_para.h
KVM: Introduce paravirtualization hints and KVM_HINTS_DEDICATED
2018-03-06 18:40:44 +01:00
linkage.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
livepatch.h
s390: include: Remove redundant license text
2017-11-24 15:37:22 +01:00
lowcore.h
s390: align struct lowcore to double page size
2018-07-02 11:25:01 +02:00
mmu_context.h
s390/vdso: correct vdso mapping for compat tasks
2019-11-20 18:47:53 +01:00
mmu.h
s390/vdso: avoid 64-bit vdso mapping for compat tasks
2019-11-20 18:47:08 +01:00
mmzone.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
module.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nmi.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
nospec-branch.h
s390: correct nospec auto detection init order
2018-04-11 17:46:00 +02:00
nospec-insn.h
s390: disable asm code expolines if cc does not support it
2018-06-25 10:14:37 +02:00
numa.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
os_info.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
page-states.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
page.h
s390/mm: Explicitly compare PAGE_DEFAULT_KEY against zero in storage_key_init_range
2020-02-28 16:39:00 +01:00
pci_clp.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pci_debug.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
pci_dma.h
s390: move s390_pci_dma_ops to asm/pci_dma.h
2018-01-10 16:41:19 +01:00
pci_insn.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
pci_io.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pci.h
s390/pci: add fmt3 fmb
2018-07-04 08:35:58 +02:00
percpu.h
s390: don't trace preemption in percpu macros
2020-09-09 19:04:23 +02:00
perf_event.h
s390/bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type
2017-12-05 15:02:41 +01:00
pgalloc.h
s390/mm: add mm_pxd_folded() checks to pxd_free()
2019-12-31 16:35:31 +01:00
pgtable.h
s390/mm: properly clear _PAGE_NOEXEC bit when it is not supported
2019-12-17 20:34:57 +01:00
pkey.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pnet.h
s390/net: add pnetid support
2018-05-30 11:18:03 +02:00
preempt.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
processor.h
s390: run user space and KVM guests with modified branch prediction
2018-02-05 14:48:50 +01:00
ptrace.h
s390/bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type
2017-12-05 15:02:41 +01:00
purgatory.h
s390/purgatory: Remove duplicate variable definitions
2018-07-06 08:47:51 +02:00
qdio.h
s390/qdio: fill SL with absolute addresses
2020-03-11 14:14:54 +01:00
runtime_instr.h
s390/runtime instrumentation: provide uapi header file
2018-02-02 10:47:15 +01:00
schid.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sclp.h
s390/hibernate: fix error handling when suspend cpu != resume cpu
2018-09-20 13:20:23 +02:00
scsw.h
s390: fix comment for scsw_cmd_is_valid_sctl
2018-02-22 15:31:24 +01:00
seccomp.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sections.h
s390: remove unused _ehead symbol
2018-07-02 11:24:58 +02:00
segment.h
s390: add a few more SPDX identifiers
2017-12-05 07:51:09 +01:00
serial.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
set_memory.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
setup.h
s390/boot: block uncompressed vmlinux booting attempts
2018-07-02 11:25:05 +02:00
shmparam.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
signal.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sigp.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
smp.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
sparsemem.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
spinlock_types.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
spinlock.h
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2017-11-13 12:38:26 -08:00
stp.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
string.h
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-11-13 11:47:01 -08:00
switch_to.h
s390: always save and restore all registers on context switch
2017-12-05 07:51:08 +01:00
syscall.h
s390: fix syscall_get_error for compat processes
2020-06-25 15:33:09 +02:00
sysinfo.h
s390/sysinfo: add and display licensed internal code identifier
2018-02-02 10:47:15 +01:00
termios.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
thread_info.h
s390: update sampling tag after task pid change
2018-04-23 07:57:17 +02:00
timex.h
s390/time: Fix clk type in get_tod_clock
2020-02-19 19:51:58 +01:00
tlb.h
s390/mm: fix mis-accounting of pgtable_bytes
2018-11-27 16:13:03 +01:00
tlbflush.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
topology.h
s390/topology: fix compile error in file arch/s390/kernel/smp.c
2017-11-20 08:51:01 +01:00
uaccess.h
s390/uaccess: avoid (false positive) compiler warnings
2019-11-06 13:06:08 +01:00
unistd.h
s390/syscalls: use generated syscall_table.h and unistd.h header files
2018-01-23 07:36:52 +01:00
uprobes.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
user.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
vdso.h
s390/vdso: fix vDSO clock_getres()
2020-06-30 23:17:14 -04:00
vga.h
s390: add a few more SPDX identifiers
2017-12-05 07:51:09 +01:00
vtime.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
vtimer.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
vx-insn.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xor.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00