Chris Wilson 7ab87ede50 drm/i915: Unwind HW init after GVT setup failure ... Following intel_gvt_init() failure, we missed unwinding our setup leaving pointers dangling past the module unload. For our example, the pm_qos: [ 441.057615] top: 000000006b3baf1c, n: 0000000054d8ef33, p: 0000000097cdf1a2 prev: 0000000054d8ef33, n: 0000000097cdf1a2, p: 000000006b3baf1c next: 0000000097cdf1a2, n: 000000006de8fc8b, p: 0000000081087253 [ 441.057627] WARNING: CPU: 4 PID: 9277 at lib/plist.c:42 plist_check_prev_next+0x2d/0x40 [ 441.057628] Modules linked in: i915(+) vgem snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic x86_pkg_temp_thermal intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec snd_hwdep snd_hda_core e1000e snd_pcm mei_me mei prime_numbers [last unloaded: i915] [ 441.057652] CPU: 4 PID: 9277 Comm: drv_selftest Tainted: G U 4.18.0-rc4-CI-CI_DRM_4464+ #1 [ 441.057653] Hardware name: System manufacturer System Product Name/Z170 PRO GAMING, BIOS 3402 04/26/2017 [ 441.057656] RIP: 0010:plist_check_prev_next+0x2d/0x40 [ 441.057657] Code: 08 48 39 f0 74 2b 49 89 f0 48 8b 4f 08 50 ff 32 52 48 89 fe 41 ff 70 08 48 8b 17 48 c7 c7 d8 ae 14 82 4d 8b 08 e8 63 0e 76 ff <0f> 0b 48 83 c4 20 c3 48 39 10 75 d0 f3 c3 0f 1f 44 00 00 41 54 55 [ 441.057717] RSP: 0018:ffffc900003a3a68 EFLAGS: 00010082 [ 441.057720] RAX: 0000000000000000 RBX: ffff8802193978c0 RCX: 0000000000000002 [ 441.057721] RDX: 0000000080000002 RSI: ffffffff820c65a4 RDI: 00000000ffffffff [ 441.057722] RBP: ffff8802193978c0 R08: 0000000000000000 R09: 0000000000000001 [ 441.057724] R10: ffffc900003a3a70 R11: 0000000000000000 R12: ffffffff82243de0 [ 441.057725] R13: ffffffff82243de0 R14: ffff88021a6c78c0 R15: 0000000077359400 [ 441.057726] FS: 00007fc23a4a9980(0000) GS:ffff880236d00000(0000) knlGS:0000000000000000 [ 441.057728] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 441.057729] CR2: 0000563e4503d038 CR3: 0000000138f86005 CR4: 00000000003606e0 [ 441.057730] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 441.057731] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 441.057732] Call Trace: [ 441.057736] plist_check_list+0x2e/0x40 [ 441.057738] plist_add+0x23/0x130 [ 441.057743] pm_qos_update_target+0x1bd/0x2f0 [ 441.057771] i915_driver_load+0xec4/0x1060 [i915] [ 441.057775] ? trace_hardirqs_on_caller+0xe0/0x1b0 [ 441.057800] i915_pci_probe+0x29/0x90 [i915] [ 441.057804] pci_device_probe+0xa1/0x130 [ 441.057807] driver_probe_device+0x306/0x480 [ 441.057810] __driver_attach+0xdb/0x100 [ 441.057812] ? driver_probe_device+0x480/0x480 [ 441.057813] ? driver_probe_device+0x480/0x480 [ 441.057816] bus_for_each_dev+0x74/0xc0 [ 441.057819] bus_add_driver+0x15f/0x250 [ 441.057821] ? 0xffffffffa0696000 [ 441.057823] driver_register+0x56/0xe0 [ 441.057825] ? 0xffffffffa0696000 [ 441.057827] do_one_initcall+0x58/0x370 [ 441.057830] ? do_init_module+0x1d/0x1ea [ 441.057832] ? rcu_read_lock_sched_held+0x6f/0x80 [ 441.057834] ? kmem_cache_alloc_trace+0x282/0x2e0 [ 441.057838] do_init_module+0x56/0x1ea [ 441.057841] load_module+0x2435/0x2b20 [ 441.057852] ? __se_sys_finit_module+0xd3/0xf0 [ 441.057854] __se_sys_finit_module+0xd3/0xf0 [ 441.057861] do_syscall_64+0x55/0x190 [ 441.057863] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 441.057865] RIP: 0033:0x7fc239d75839 [ 441.057866] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48 [ 441.057927] RSP: 002b:00007fffb7825d38 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 441.057930] RAX: ffffffffffffffda RBX: 0000563e45035dd0 RCX: 00007fc239d75839 [ 441.057931] RDX: 0000000000000000 RSI: 0000563e4502f8a0 RDI: 0000000000000004 [ 441.057932] RBP: 0000563e4502f8a0 R08: 0000000000000004 R09: 0000000000000000 [ 441.057933] R10: 00007fffb7825ea0 R11: 0000000000000246 R12: 0000000000000000 [ 441.057934] R13: 0000563e4502f690 R14: 0000000000000000 R15: 000000000000003f [ 441.057940] irq event stamp: 231338 [ 441.057943] hardirqs last enabled at (231337): [<ffffffff8193e3fc>] _raw_spin_unlock_irqrestore+0x4c/0x60 [ 441.057944] hardirqs last disabled at (231338): [<ffffffff8193e26d>] _raw_spin_lock_irqsave+0xd/0x50 [ 441.057947] softirqs last enabled at (231024): [<ffffffff81c0034f>] __do_softirq+0x34f/0x505 [ 441.057949] softirqs last disabled at (231005): [<ffffffff8108c7b9>] irq_exit+0xa9/0xc0 [ 441.057951] WARNING: CPU: 4 PID: 9277 at lib/plist.c:42 plist_check_prev_next+0x2d/0x40 v2: Add a load failure point to intel_gvt_init() so that we always exercise this path in future. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107129 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Michał Winiarski <michal.winiarski@intel.com> Reviewed-by: Michał Winiarski <michal.winiarski@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180710143821.1889-1-chris@chris-wilson.co.uk		2018-07-10 16:46:09 +01:00
..
accessibility
acpi	ACPI fixes for 4.17-rc3	2018-04-26 11:06:36 -07:00
amba	ARM: amba: Fix race condition with driver_override	2018-04-26 10:35:04 +02:00
android	ANDROID: binder: prevent transactions into own process.	2018-04-23 12:12:41 +02:00
ata	Merge branch 'for-4.17' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2018-04-03 17:42:25 -07:00
atm	atm: iphase: fix spelling mistake: "Tansmit" -> "Transmit"	2018-04-19 13:41:49 -04:00
auxdisplay
base	Driver core fixes for 4.17-rc3	2018-04-27 10:12:20 -07:00
bcma
block	for-linus-20180425	2018-04-25 21:05:15 -07:00
bluetooth	Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME	2018-04-01 21:43:02 +03:00
bus	HISI LPC: Add Kconfig MFD_CORE dependency	2018-04-26 16:53:23 +02:00
cdrom	cdrom: information leak in cdrom_ioctl_media_changed()	2018-04-18 08:21:32 -06:00
char	virtio: fixups	2018-04-26 16:36:11 -07:00
clk	The large diff this time around is from the addition of a new clk driver	2018-04-13 15:51:06 -07:00
clocksource	clocksource/imx-tpm: Correct -ETIME return condition check	2018-04-19 13:21:35 +02:00
connector
cpufreq	powerpc fixes for 4.17 #4	2018-04-28 09:45:34 -07:00
cpuidle	cpuidle: menu: Avoid selecting shallow states with stopped tick	2018-04-09 11:54:57 +02:00
crypto	.gitignore: move *-asn1.[ch] patterns to the top-level .gitignore	2018-04-07 19:04:02 +09:00
dax	device-dax: allow MAP_SYNC to succeed	2018-04-19 15:11:50 -07:00
dca
devfreq
dio
dma	DMAengine updates for v4.17-rc1	2018-04-10 12:14:37 -07:00
dma-buf
edac	* Add NVDIMM support to EDAC (Tony Luck)	2018-04-05 14:21:13 -07:00
eisa
extcon	Char/Misc patches for 4.17-rc1	2018-04-04 20:07:20 -07:00
firewire
firmware	firmware: arm_scmi: remove redundant null check on array	2018-04-16 10:15:58 +01:00
fmc	treewide: Fix typos in printk	2018-03-27 09:51:22 +02:00
fpga	fpga-manager: altera-ps-spi: preserve nCONFIG state	2018-04-23 13:27:05 +02:00
fsi
gpio	DeviceTree updates for 4.17:	2018-04-05 21:03:42 -07:00
gpu	drm/i915: Unwind HW init after GVT setup failure	2018-07-10 16:46:09 +01:00
hid	HID: i2c-hid: fix inverted return value from i2c_hid_command()	2018-04-19 09:25:15 +02:00
hsi
hv	ARM:	2018-04-09 11:42:31 -07:00
hwmon	hwmon: (k10temp) Add support for AMD Ryzen w/ Vega graphics	2018-04-25 05:31:06 -07:00
hwspinlock
hwtracing	Char/Misc patches for 4.17-rc1	2018-04-04 20:07:20 -07:00
i2c	i2c: sprd: Fix the i2c count issue	2018-04-27 14:12:43 +02:00
ide	for-4.17/block-20180402	2018-04-05 14:27:02 -07:00
idle
iio	This is the bulk of GPIO changes for the v4.17 kernel cycle:	2018-04-05 09:51:41 -07:00
infiniband	Merge candidates for 4.17 merge window	2018-04-06 17:35:43 -07:00
input	Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME	2018-04-26 14:53:32 +02:00
iommu	IOMMU Updates for Linux v4.17	2018-04-11 18:50:41 -07:00
ipack
irqchip	IOMMU Updates for Linux v4.17	2018-04-11 18:50:41 -07:00
isdn	mISDN: Remove VLAs	2018-04-12 21:46:10 -04:00
leds
lightnvm	lightnvm: pblk: remove some unnecessary NULL checks	2018-03-29 17:29:09 -06:00
macintosh	powerpc updates for 4.17	2018-04-07 12:08:19 -07:00
mailbox
mcb
md	Merge tag 'md/4.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md	2018-04-20 10:39:44 -07:00
media	remoteproc updates for v4.17	2018-04-10 12:09:27 -07:00
memory	ARM: OMAP2+: Fix build when using split object directories	2018-04-18 10:07:13 -07:00
memstick
message	scsi: mptsas: Disable WRITE SAME	2018-04-18 23:37:25 -04:00
mfd	platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle	2018-04-10 22:25:07 -07:00
misc	* Fix 2032 time access issues and new compiler warnings	2018-04-12 10:21:19 -07:00
mmc	MMC host:	2018-04-20 10:41:31 -07:00
mtd	mtd: rawnand: marvell: fix the chip-select DT parsing logic	2018-04-26 19:06:42 +02:00
mux
net	Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue	2018-04-24 16:17:59 -04:00
nfc
ntb
nubus
nvdimm	Revert "libnvdimm, of_pmem: workaround OF_NUMA=n build error"	2018-04-19 15:10:56 -07:00
nvme	nvme: expand nvmf_check_if_ready checks	2018-04-12 09:58:27 -06:00
nvmem	Char/Misc patches for 4.17-rc1	2018-04-04 20:07:20 -07:00
of	earlycon: Use a pointer table to fix __earlycon_table stride	2018-04-23 10:06:59 +02:00
opp
oprofile	oprofilefs: don't oops on allocation failure	2018-03-29 15:07:48 -04:00
parisc	parisc/pci: Switch LBA PCI bus from Hard Fail to Soft Fail mode	2018-03-27 18:52:22 +02:00
parport	Char/Misc patches for 4.17-rc1	2018-04-04 20:07:20 -07:00
pci	pci-v4.17-fixes-1	2018-04-26 16:28:24 -07:00
pcmcia	Merge branch 'for-linus-sa1100' of git://git.armlinux.org.uk/~rmk/linux-arm	2018-04-09 09:26:36 -07:00
perf	ARM: SoC driver updates for 4.17	2018-04-05 21:29:35 -07:00
phy	ARM: SoC platform updates for 4.17	2018-04-05 21:21:08 -07:00
pinctrl	This is the bulk of GPIO changes for the v4.17 kernel cycle:	2018-04-05 09:51:41 -07:00
platform	Changes to chrome-platform for v4.17	2018-04-13 16:20:36 -07:00
pnp
power	ARM: SoC platform updates for 4.17	2018-04-05 21:21:08 -07:00
powercap
pps
ps3
ptp
pwm	pwm: Changes for v4.17-rc1	2018-04-13 15:46:21 -07:00
rapidio	rapidio: fix rio_dma_transfer error handling	2018-04-20 17:18:35 -07:00
ras
regulator	Merge remote-tracking branches 'regulator/topic/88pg86x', 'regulator/topic/dt', 'regulator/topic/formatting' and 'regulator/topic/gpio' into regulator-next	2018-03-28 10:33:53 +08:00
remoteproc	remoteproc: fix null pointer dereference on glink only platforms	2018-04-05 22:53:16 -07:00
reset	Merge branch 'reset/lookup' into reset/next	2018-03-27 11:03:43 +02:00
rpmsg	rpmsg: smd: Use announce_create to process any receive work	2018-03-27 21:54:37 -07:00
rtc	rtc: opal: Fix OPAL RTC driver OPAL_BUSY loops	2018-04-25 13:24:13 +10:00
s390	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2018-04-26 10:29:46 -07:00
sbus	sparc64: Properly range check DAX completion index	2018-04-01 20:07:00 -04:00
scsi	scsi: sd_zbc: Avoid that resetting a zone fails sporadically	2018-04-19 00:04:10 -04:00
sfi
sh
siox
slimbus	slimbus: Fix out-of-bounds access in slim_slicesize()	2018-04-23 13:40:15 +02:00
sn
soc	soc: bcm: raspberrypi-power: Fix use of __packed	2018-04-16 15:15:23 -07:00
soundwire
spi	spi: SPI updates for v4.17	2018-04-03 12:06:21 -07:00
spmi
ssb
staging	drm-misc-next for v4.18:	2018-04-30 09:32:43 +10:00
target	scsi: target: fix crash with iscsi target and dvd	2018-04-19 00:41:03 -04:00
tc
tee
thermal	Merge branches 'thermal-core' and 'thermal-soc' into next	2018-04-13 14:11:53 +08:00
thunderbolt
tty	tty: Use __GFP_NOFAIL for tty_ldisc_get()	2018-04-25 15:03:44 +02:00
uio	uio_hv_generic: fix subchannel ring mmap	2018-04-23 12:43:48 +02:00
usb	USB-serial fixes for v4.17-rc3	2018-04-26 19:29:24 +02:00
uwb
vfio	VFIO updates for v4.17-rc1	2018-04-06 19:44:27 -07:00
vhost	vhost: return bool from *_access_ok() functions	2018-04-11 10:54:06 -04:00
video	fbdev changes for v4.17:	2018-04-10 10:20:00 -07:00
virt	virt: vbox: Log an error when we fail to get the host version	2018-04-23 13:41:55 +02:00
virtio	virtio: feature	2018-04-11 18:58:27 -07:00
visorbus
vlynq
vme
w1
watchdog	aspeed: watchdog: Set bootstatus during probe	2018-04-16 10:22:40 +02:00
xen	xen: fixes and one header update for 4.17-rc2	2018-04-20 08:36:04 -07:00
zorro
Kconfig	hwtracing: Add HW tracing support menu	2018-03-29 13:38:10 +03:00
Makefile