Alexander Kuznetsov
d2625eba1e
cgroup1: don't allow '\n' in renaming
commit b7e24eb1ca upstream.
cgroup_mkdir() have restriction on newline usage in names:
$ mkdir $'/sys/fs/cgroup/cpu/test\ntest2'
mkdir: cannot create directory
'/sys/fs/cgroup/cpu/test\ntest2': Invalid argument
But in cgroup1_rename() such check is missed.
This allows us to make /proc/<pid>/cgroup unparsable:
$ mkdir /sys/fs/cgroup/cpu/test
$ mv /sys/fs/cgroup/cpu/test $'/sys/fs/cgroup/cpu/test\ntest2'
$ echo $$ > $'/sys/fs/cgroup/cpu/test\ntest2'
$ cat /proc/self/cgroup
11:pids:/
10:freezer:/
9:hugetlb:/
8:cpuset:/
7:blkio:/user.slice
6:memory:/user.slice
5:net_cls,net_prio:/
4:perf_event:/
3:devices:/user.slice
2:cpu,cpuacct:/test
test2
1:name=systemd:/
0::/
Signed-off-by: Alexander Kuznetsov <wwfq@yandex-team.ru>
Reported-by: Andrey Krasichkov <buglloc@yandex-team.ru>
Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
Cc: stable@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-16 11:53:02 +02:00
..
2021-06-10 12:43:53 +02:00
2021-06-16 11:53:02 +02:00
2021-03-03 18:22:36 +01:00
2020-11-18 18:28:02 +01:00
2020-09-23 10:46:32 +02:00
2021-03-24 11:05:06 +01:00
2019-10-07 18:55:09 +02:00
2021-01-30 13:31:16 +01:00
2020-10-29 09:07:16 +01:00
2021-03-03 18:22:55 +01:00
2019-05-31 06:47:33 -07:00
2021-06-10 12:43:53 +02:00
2021-05-22 10:57:22 +02:00
2021-05-22 10:57:25 +02:00
2020-10-01 13:12:33 +02:00
2020-06-20 10:25:10 +02:00
2020-06-20 10:25:10 +02:00
2020-06-20 10:25:10 +02:00
2019-12-01 09:14:03 +01:00
2018-11-13 11:15:08 -08:00
2020-06-20 10:24:58 +02:00
2020-06-20 10:25:19 +02:00
2020-12-29 13:46:47 +01:00
2020-01-09 10:17:54 +01:00
2018-08-03 07:50:38 +02:00
2020-11-18 18:27:58 +01:00
2020-11-10 10:29:06 +01:00
2021-05-22 10:57:22 +02:00
2019-04-20 09:15:05 +02:00
2018-12-05 19:41:17 +01:00
2019-09-21 07:15:38 +02:00
2018-08-03 07:50:22 +02:00
2019-11-24 08:23:15 +01:00
2021-05-22 10:57:39 +02:00
2020-04-24 08:00:44 +02:00
2021-02-10 09:12:09 +01:00
2021-02-07 14:47:41 +01:00
2021-02-10 09:12:08 +01:00
2019-01-13 10:01:02 +01:00
2021-05-22 10:57:24 +02:00
2020-04-02 16:34:20 +02:00
2020-05-27 16:43:05 +02:00
2019-10-17 13:43:19 -07:00
2019-07-31 07:28:21 +02:00
2021-05-26 11:46:58 +02:00
2020-11-18 18:28:02 +01:00
2020-08-26 10:29:54 +02:00
2021-03-03 18:22:53 +01:00
2020-04-24 08:00:38 +02:00
2021-05-22 10:57:35 +02:00
2021-02-07 14:47:41 +01:00
2018-08-15 18:12:47 +02:00
2018-09-05 09:26:36 +02:00
2020-10-01 13:12:30 +02:00
2020-01-04 13:59:57 +01:00
2020-01-09 10:17:53 +01:00
2021-03-03 18:22:47 +01:00
2020-10-14 09:51:10 +02:00
2021-05-22 10:57:35 +02:00
2018-09-09 19:56:00 +02:00
2018-09-09 19:56:00 +02:00
2018-09-05 09:26:42 +02:00
2020-02-28 16:36:05 +01:00
2021-06-16 11:53:01 +02:00