George Kennedy
0c0e566f03
tun: avoid double free in tun_free_netdev
commit 158b515f70 upstream.
Avoid double free in tun_free_netdev() by moving the
dev->tstats and tun->security allocs to a new ndo_init routine
(tun_net_init()) that will be called by register_netdevice().
ndo_init is paired with the desctructor (tun_free_netdev()),
so if there's an error in register_netdevice() the destructor
will handle the frees.
BUG: KASAN: double-free or invalid-free in selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605
CPU: 0 PID: 25750 Comm: syz-executor416 Not tainted 5.16.0-rc2-syzk #1
Hardware name: Red Hat KVM, BIOS
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x89/0xb5 lib/dump_stack.c:106
print_address_description.constprop.9+0x28/0x160 mm/kasan/report.c:247
kasan_report_invalid_free+0x55/0x80 mm/kasan/report.c:372
____kasan_slab_free mm/kasan/common.c:346 [inline]
__kasan_slab_free+0x107/0x120 mm/kasan/common.c:374
kasan_slab_free include/linux/kasan.h:235 [inline]
slab_free_hook mm/slub.c:1723 [inline]
slab_free_freelist_hook mm/slub.c:1749 [inline]
slab_free mm/slub.c:3513 [inline]
kfree+0xac/0x2d0 mm/slub.c:4561
selinux_tun_dev_free_security+0x1a/0x20 security/selinux/hooks.c:5605
security_tun_dev_free_security+0x4f/0x90 security/security.c:2342
tun_free_netdev+0xe6/0x150 drivers/net/tun.c:2215
netdev_run_todo+0x4df/0x840 net/core/dev.c:10627
rtnl_unlock+0x13/0x20 net/core/rtnetlink.c:112
__tun_chr_ioctl+0x80c/0x2870 drivers/net/tun.c:3302
tun_chr_ioctl+0x2f/0x40 drivers/net/tun.c:3311
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl fs/ioctl.c:860 [inline]
__x64_sys_ioctl+0x19d/0x220 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3a/0x80 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: George Kennedy <george.kennedy@oracle.com>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/1639679132-19884-1-git-send-email-george.kennedy@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[DP: adjusted context for 5.4 stable]
Signed-off-by: Dragos-Marian Panait <dragos.panait@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-04-05 11:16:41 +02:00
..
2023-03-11 16:43:56 +01:00
2022-12-08 11:23:01 +01:00
2023-02-22 12:50:24 +01:00
2023-04-05 11:16:37 +02:00
2023-02-06 07:52:40 +01:00
2023-03-22 13:28:06 +01:00
2023-04-05 11:16:38 +02:00
2023-02-22 12:50:23 +01:00
2023-03-17 08:32:53 +01:00
2023-03-22 13:28:03 +01:00
2023-01-18 11:40:56 +01:00
2023-01-18 11:41:24 +01:00
2023-02-06 07:52:41 +01:00
2023-01-18 11:40:53 +01:00
2023-03-11 16:43:42 +01:00
2023-01-18 11:41:52 +01:00
2023-01-18 11:41:21 +01:00
2023-03-03 11:41:48 +01:00
2023-02-06 07:52:44 +01:00
2023-02-22 12:50:22 +01:00
2023-03-11 16:43:58 +01:00
2023-02-22 12:50:28 +01:00
2023-02-22 12:50:23 +01:00
2023-03-11 16:43:47 +01:00
2023-03-22 13:28:09 +01:00
2023-03-22 13:28:10 +01:00
2023-01-18 11:41:28 +01:00
2022-12-08 11:22:58 +01:00
2023-04-05 11:16:38 +02:00
2023-04-05 11:16:41 +02:00
2023-03-11 16:44:15 +01:00
2023-03-03 11:41:48 +01:00
2023-03-11 16:43:51 +01:00
2023-03-22 13:28:08 +01:00
2023-03-17 08:32:50 +01:00
2023-03-11 16:43:43 +01:00
2023-01-18 11:41:32 +01:00
2023-03-17 08:32:52 +01:00
2023-01-18 11:41:33 +01:00
2023-01-18 11:41:25 +01:00
2023-04-05 11:16:41 +02:00
2023-03-22 13:28:07 +01:00
2023-02-06 07:52:34 +01:00
2023-03-11 16:44:13 +01:00
2023-03-11 16:44:14 +01:00
2023-03-22 13:28:07 +01:00
2023-03-11 16:44:10 +01:00
2023-04-05 11:16:41 +02:00
2023-03-22 13:28:05 +01:00
2023-03-22 13:28:06 +01:00
2023-02-22 12:50:28 +01:00
2023-01-18 11:41:14 +01:00
2023-03-11 16:43:41 +01:00
2023-01-18 11:41:50 +01:00
2022-11-25 17:42:14 +01:00
2023-03-22 13:28:09 +01:00
2023-01-18 11:40:50 +01:00
2023-03-11 16:44:15 +01:00
2023-03-11 16:43:57 +01:00
2023-04-05 11:16:38 +02:00
2023-01-18 11:40:54 +01:00
2023-04-05 11:16:36 +02:00
2023-03-11 16:43:40 +01:00
2023-03-11 16:44:08 +01:00
2023-01-18 11:40:59 +01:00
2023-03-11 16:43:57 +01:00
2023-03-11 16:43:52 +01:00
2023-03-11 16:43:53 +01:00
2023-03-11 16:44:13 +01:00
2023-03-17 08:32:54 +01:00
2023-04-05 11:16:40 +02:00
2022-11-25 17:42:14 +01:00
2022-11-25 17:42:17 +01:00
2023-01-18 11:41:46 +01:00
2023-03-11 16:43:47 +01:00
2023-03-13 10:18:25 +01:00
2023-04-05 11:16:39 +02:00
2022-12-08 11:22:57 +01:00
2023-03-11 16:44:13 +01:00
2023-04-05 11:16:39 +02:00
2023-04-05 11:16:38 +02:00
2023-01-18 11:41:22 +01:00
2023-04-05 11:16:41 +02:00
2023-01-18 11:41:22 +01:00
2023-01-18 11:41:57 +01:00
2023-03-22 13:28:09 +01:00
2023-01-18 11:41:26 +01:00
2023-02-06 07:52:40 +01:00
2023-03-11 16:44:11 +01:00
2023-02-22 12:50:23 +01:00